add .js extension to react runtime for JSX transform
#12116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d6b0822:
|
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28940/ |
lunaruan
force-pushed
the
js_extension
branch
from
9ff9aa4 to
d6b0822
Compare
JLHwung
approved these changes
Sep 29, 2020
Contributor
JLHwung
left a comment
JLHwung
left a comment
There was a problem hiding this comment.
Since Automatic JSX transform does not work with AMD be design (facebook/react#18299 (comment)). Adding .js will not cause issues like #10832.
nicolo-ribaudo
added
area: react
PR: Bug Fix 🐛
Contributor
|
I'm afraid that despite good intentions, this is a breaking change and broke the build pipeline for a few Preact users preactjs/preact#2801 :S Made #12210 to continue the discussion |
nicolo-ribaudo
added a commit
that referenced
this pull request
Oct 19, 2020
This reverts commit 9808d25.
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we transformed JSX, we auto imported from
${source}/jsx-runtimeand${source}/jsx-dev-runtime. However, these functions don't have extensions, which will not work for vanilla JS imports (and might not work for in the future for Node). This PR adds the.jsextension to the auto import source so now we will auto import from${source}/jsx-runtime.jsand${source}/jsx-dev-runtime.js.