Skip to content

Throw a syntax error for empty type parameter/argument #12088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
existentialism merged 3 commits into from
Sep 22, 2020
Merged

Throw a syntax error for empty type parameter/argument #12088

existentialism merged 3 commits into from
Sep 22, 2020

Conversation

@sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Sep 20, 2020 •
edited by gitpod-io bot
Loading

I created this PR because #9968 is not progressing. If there is a problem, please close this.

Q                       A
Fixed Issues? Fixes #9462 Closes #9968
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 20, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28665/

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript pkg: parser labels Sep 21, 2020
JLHwung
JLHwung approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

kaicataldo
kaicataldo approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@existentialism existentialism merged commit a4a14ca into babel:main Sep 22, 2020
@sosukesuzuki sosukesuzuki deleted the fix-9462 branch September 22, 2020 22:59
@fisker fisker mentioned this pull request Oct 15, 2020
Merged
3 tasks
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeScript: missing error on empty typeArguments and typeParameters

5 participants

@sosukesuzuki @babel-bot @existentialism @JLHwung @kaicataldo