chore: use latest node on ci workflow when possible #12049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28350/ |
JLHwung
force-pushed
the
use-latest-node-on-github-ci
branch
from
49f3a4c to
67dfeef
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 67dfeef:
|
Contributor
|
Didn't notice this difference. 👍 |
existentialism
approved these changes
Sep 10, 2020
Contributor
Author
|
I am merging with one approval since it does not change the codebase and @fisker has reviewed. |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts change implemented in #11952 where
node-versionis removed./cc @fisker
Per
actions/setup-nodedocsCurrently, when
node-versionis not set, it refers to v12 LTS: https://github.com/JLHwung/babel/runs/1093487909#step:6:8When
node-versionis set to*, it refers to v14: https://github.com/babel/babel/pull/12049/checks?check_run_id=1093534529#step:3:7