[cjs] Skip duplicate reexported bindings in namespace reexports #11739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 87938ed:
|
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28760/ |
| Object.keys(NAMESPACE).forEach(function(key) { | ||
| if (key === "default" || key === "__esModule") return; | ||
| VERIFY_NAME_LIST; | ||
| if (key in EXPORTS && EXPORTS[key] === NAMESPACE[key]) return; |
Member
There was a problem hiding this comment.
Since this is technically not spec compliant, could you add a comment explaining the reason to do it?
Contributor
Author
There was a problem hiding this comment.
Done (directly above the template string)
nicolo-ribaudo
added
area: modules
PR: Bug Fix 🐛
mischnic
force-pushed
the
reexports-duplicate-symbols
branch
from
fa8bd25 to
d7f8014
Compare
JLHwung
approved these changes
Jul 16, 2020
Contributor
JLHwung
left a comment
JLHwung
left a comment
There was a problem hiding this comment.
Can you update the test fixtures?
mischnic
force-pushed
the
reexports-duplicate-symbols
branch
from
d7f8014 to
199055a
Compare
Contributor
Author
Done |
mischnic
force-pushed
the
reexports-duplicate-symbols
branch
from
199055a to
341a776
Compare
mischnic
force-pushed
the
reexports-duplicate-symbols
branch
from
341a776 to
87938ed
Compare
nicolo-ribaudo
approved these changes
Sep 28, 2020
nicolo-ribaudo
changed the title
Member
|
Thanks! |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace reexports: skip already added reexports on the
exportsobject if they are strictly equal (as suggested in #11710 (comment)).Questions:
Object.definePropertydoes this automatically). However, the order of the objects should be the same (because both skip if already set).