feat: add rule consistent-each-for #826
Merged
+476
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
veritem
requested changes
Nov 23, 2025
src/rules/consistent-each-for.ts
Outdated
Comment on lines
7
to
8
| export type EachOrFor = 'each' | 'for' | ||
| export type BaseFnName = 'test' | 'it' | 'describe' | 'suite' |
Member
There was a problem hiding this comment.
do you have any reason to why these are exported?
Contributor
Author
There was a problem hiding this comment.
You're right - these are only used internally. I've removed the exports to match the pattern I see in consistent-test-it and other rules. Thanks for pointing that out!
veritem
requested changes
Nov 23, 2025
tests/consistent-each-for.test.ts
Outdated
| { | ||
| name: 'test.only.each when configured to prefer each', | ||
| code: 'test.only.each([1, 2, 3])("test", (n) => { expect(n).toBeDefined() })', | ||
| options: [{ test: 'each' as const }], |
Member
There was a problem hiding this comment.
why are these marked const? I'm curious?
Contributor
Author
There was a problem hiding this comment.
I realized it's unnecessary here - TypeScript already infers the literal types correctly since the values match the union type. Removed all instances.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #702
Add
vitest/consistent-each-forrule to enforce consistent usage of.eachor.forfor parameterized tests acrosstest,it,describe, andsuitefunctions.