expose cwd and config_dir via program options #1928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
approved these changes
Oct 5, 2025
Contributor
Author
|
Hey thanks @johanneswuerbach for running the CI job (at least I assume it was you 😂 ) It looks like the test failures aren't actually related to this change 🤔 is there something I can do to help unblock this or is it all just going to be stuff on your side? |
Member
|
@mansona yes it was me, I'll try to find some time to look into those CI failures today, the pipeline wasn't used for some time :-/ |
Member
|
CI on main should be green again, would you mind rebasing your branch? |
Contributor
Author
|
@johanneswuerbach done! I think I need another approval though for CI 🫠 😂 |
Contributor
Author
|
@johanneswuerbach it looks like the latest release didn't make it to npm 🤔 is this an automated thing or do you do releases manually? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to have a programatic build of your test assets and pass into the testem binary where the build location actually is.
Note: I only exposed
config_dirbecause I needed the config to still stay inprocess.cwd(). I think it might make more sense to always search for config inprocess.cwd()but that's obviously a change that would need a major bump so I'm not necessarily proposing it right now.