Fix [#407] Make Performance/DoubleStartEndWith aware of safe navigation
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Sep 13, 2024
| @@ -0,0 +1 @@ | |||
| * [#407](https://github.com/rubocop/rubocop-performance/issues/407): Make `Performance/DoubleStartEndWith` aware of safe navigation. ([@earlopain][]) | |||
There was a problem hiding this comment.
It would probably be better to start the file name with change_ instad of fix_.
… navigation In case of inconsistent safe navigation, it keeps the dot from the first receiver. This shouldn't change anything: Depending on the order, it was either not needed or it will continue raising. `Lint/SafeNavigationConsistency` takes care of this anyways
Earlopain
force-pushed
the
start-end-safe-navigation
branch
from
ca4f322 to
767f2c9
Compare
I like this approach. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #407.
In case of inconsistent safe navigation, it keeps the dot from the first receiver.
This shouldn't change anything:
Depending on the order, it was either not needed or it will continue raising.
Lint/SafeNavigationConsistencytakes care of this anywaysBefore submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.