Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Performance/DoubleStartEndWith aware of safe navigation operator #407

Closed
ydakuka opened this issue Dec 1, 2023 · 0 comments · Fixed by #465
Closed

Make Performance/DoubleStartEndWith aware of safe navigation operator #407

ydakuka opened this issue Dec 1, 2023 · 0 comments · Fixed by #465
Labels
enhancement

Comments

@ydakuka
Copy link
Contributor

ydakuka commented Dec 1, 2023

Describe the solution you'd like

# bad
def my_method
  str&.start_with?('a') || str&.start_with?(Some::CONST)
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.58.0 (using Parser 3.2.2.4, rubocop-ast 1.30.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
@ydakuka ydakuka changed the title Make `Performance/DoubleStartEndWith aware of safe navigation operator Make Performance/DoubleStartEndWith aware of safe navigation operator Dec 1, 2023
Earlopain added a commit to Earlopain/rubocop-performance that referenced this issue Sep 13, 2024
@Earlopain
Fix [rubocop#407]Make Performance/DoubleStartEndWith aware of safe …
5140412 
…navigation

In case of inconsistent safe navigation, it keeps the dot from the first receiver.

This shouldn't change anything:
Depending on the order, it was either not needed or it will continue raising.

`Lint/SafeNavigationConsistency``takes care of this anyways
Earlopain added a commit to Earlopain/rubocop-performance that referenced this issue Sep 13, 2024
@Earlopain
Fix [rubocop#407] Make Performance/DoubleStartEndWith aware of safe…
ca4f322 
… navigation

In case of inconsistent safe navigation, it keeps the dot from the first receiver.

This shouldn't change anything:
Depending on the order, it was either not needed or it will continue raising.

`Lint/SafeNavigationConsistency``takes care of this anyways
@Earlopain Earlopain mentioned this issue Sep 13, 2024
Merged
8 tasks
@koic koic closed this as completed in #465 Sep 14, 2024
@koic koic closed this as completed in 767f2c9 Sep 14, 2024
koic added a commit that referenced this issue Sep 14, 2024
@koic
Merge pull request #465 from Earlopain/start-end-safe-navigation
7233005 
Fix [#407] Make `Performance/DoubleStartEndWith` aware of safe navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix [#407] Make Performance/DoubleStartEndWith aware of safe navigation Earlopain/rubocop-performance
2 participants
@koic @ydakuka