Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Style/IfWithSemicolon #13191

Merged

Conversation

koic
Copy link
Member

@koic koic commented Sep 3, 2024

This PR fixes the following error for Style/IfWithSemicolon when when using nested single-line if/;/end in block of if/else branches.

$ cat /tmpp/example.rb
if foo?;bar;else baz do if qux;else quux;end;end;end

$ bundle exec rubocop --only Style/IfWithSemicolon /tmp/example.rb -a -d
(snip)

An error occurred while Style/IfWithSemicolon cop was inspecting /tmp/example.rb:1:24.
Parser::Source::TreeRewriter detected clobbering
/Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/parser-3.3.4.2/lib/parser/source/tree_rewriter.rb:427
:in 'Parser::Source::TreeRewriter#trigger_policy'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following error for `Style/IfWithSemicolon`
when when using nested single-line if/;/end in block of if/else branches.

```console
$ cat /tmpp/example.rb
if foo?;bar;else baz do if qux;else quux;end;end;end

$ bundle exec rubocop --only Style/IfWithSemicolon /tmp/example.rb -a -d
(snip)

An error occurred while Style/IfWithSemicolon cop was inspecting /tmp/example.rb:1:24.
Parser::Source::TreeRewriter detected clobbering
/Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/parser-3.3.4.2/lib/parser/source/tree_rewriter.rb:427
:in 'Parser::Source::TreeRewriter#trigger_policy'
```
@bbatsov bbatsov merged commit 08bed81 into rubocop:master Sep 4, 2024
22 checks passed
@koic koic deleted the fix_an_error_for_style_if_with_semicolon branch September 4, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants