Skip to content

Fix false positive for Style/EmptyLiteral with Hash.new([]) #13178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koic merged 1 commit into from
Sep 1, 2024
Merged

Fix false positive for Style/EmptyLiteral with Hash.new([]) #13178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/fix_false_positive_empty_literal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* [#13178](https://github.com/rubocop/rubocop/pull/13178): Fix false positive for `Style/EmptyLiteral` with `Hash.new([])`. ([@earlopain][])
2 changes: 1 addition & 1 deletion lib/rubocop/cop/style/empty_literal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class EmptyLiteral < Base
def_node_matcher :array_node, '(send (const {nil? cbase} :Array) :new (array)?)'

# @!method hash_node(node)
def_node_matcher :hash_node, '(send (const {nil? cbase} :Hash) :new (array)?)'
def_node_matcher :hash_node, '(send (const {nil? cbase} :Hash) :new)'

# @!method str_node(node)
def_node_matcher :str_node, '(send (const {nil? cbase} :String) :new)'
Expand Down
5 changes: 4 additions & 1 deletion spec/rubocop/cop/style/empty_literal_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
it_behaves_like 'registers_and_corrects', initializer: 'Hash.new()'
it_behaves_like 'registers_and_corrects', initializer: 'Hash.new'
it_behaves_like 'registers_and_corrects', initializer: '::Hash.new()'
it_behaves_like 'registers_and_corrects', initializer: 'Hash.new([])'
it_behaves_like 'registers_and_corrects', initializer: 'Hash[]'
it_behaves_like 'registers_and_corrects', initializer: 'Hash([])'
end
Expand Down Expand Up @@ -107,6 +106,10 @@
expect_no_offenses('test = ::Hash.new { block }')
end

it 'does not register an offense for Hash.new([])' do
expect_no_offenses('Hash.new([])')
end

context 'Ruby 2.7', :ruby27 do
it 'does not register an offense for Hash.new { _1[_2] = [] }' do
expect_no_offenses('test = Hash.new { _1[_2] = [] }')
Expand Down