Raise before exceeding a part limit, not after #2362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-puku
force-pushed
the
feature/check-parts-early
branch
from
16cff63 to
6ebe026
Compare
jeremyevans
approved these changes
Jul 30, 2025
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
Implementation wise, it's fine to split the checks, and a bit more efficient to not check file part limit if it isn't a file. So this looks good.
ioquatix
reviewed
Jul 31, 2025
ioquatix
force-pushed
the
feature/check-parts-early
branch
from
077090e to
1504d45
Compare
ioquatix
pushed a commit
that referenced
this pull request
Jul 31, 2025
ioquatix
pushed a commit
that referenced
this pull request
Jul 31, 2025
d1ceward
pushed a commit
to HappyRenting/rack
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2300.
I can have a go at writing tests which spy on internals to verify this change, if desired.