Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path resolution for angular.json #813

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

xjarvik
Copy link
Contributor

@xjarvik xjarvik commented Dec 10, 2024

Describe your changes

Changed the code that looks up the angular.json so that it uses the absolute "ui dir" path (which is based on the project directory) instead of basing the path off the working directory.

Fixes Issue

Fix #812

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@xjarvik xjarvik requested a review from a team as a code owner December 10, 2024 11:56
@melloware melloware added this to the 2.5.1 milestone Dec 10, 2024
@melloware
Copy link
Contributor

Nice work!

@melloware melloware merged commit 306c39e into quarkiverse:main Dec 10, 2024
2 checks passed
@melloware
Copy link
Contributor

@all-contributors add @xjarvik for code

Copy link
Contributor

@melloware

I've put up a pull request to add @xjarvik! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find angular.json when working directory is not the same as the project directory
2 participants