Skip to content

Conversation

@bschoenmaeckers
Copy link
Contributor

@bschoenmaeckers bschoenmaeckers commented May 24, 2023

Change Summary

The Hypothesis plugin couldn't generate FutureDate and/or PastDate fields initially. So I tweaked the plugin to support those fields too.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @hramezani

@bschoenmaeckers
Copy link
Contributor Author

please review

@hramezani
Copy link
Member

hramezani commented May 25, 2023

Thanks @bschoenmaeckers for adding this.

Please add a change file with the format described in the PR body and describe the change.

Other than that LGTM

please update

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels May 25, 2023
@samuelcolvin samuelcolvin added V1 bug V1 Bug related to Pydantic V1.X and removed V1 labels May 28, 2023
@bschoenmaeckers
Copy link
Contributor Author

Added the changelog. Should be good to go now!

@bschoenmaeckers
Copy link
Contributor Author

please review

@pydantic-hooky pydantic-hooky bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels May 31, 2023
@hramezani
Copy link
Member

Thanks @bschoenmaeckers

@hramezani hramezani merged commit 0813a03 into pydantic:1.10.X-fixes Jun 1, 2023
@bschoenmaeckers bschoenmaeckers deleted the futuredate-hypothesis branch September 25, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug V1 Bug related to Pydantic V1.X ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants