Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the primer/colors variable #491

Merged
merged 13 commits into from
Sep 26, 2024
Merged

Refactor the primer/colors variable #491

merged 13 commits into from
Sep 26, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 25, 2024

Refactoring the primer/colors rule to use primitive values that match up with props. This change is different than before as we were only fuzzy matching primer variables, now they're found to exist before failing.

closes https://github.com/github/primer/issues/4029

Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: 3a0d848

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/stylelint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@jonrohan jonrohan marked this pull request as ready for review September 26, 2024 21:51
@jonrohan jonrohan requested a review from a team as a code owner September 26, 2024 21:51
@jonrohan jonrohan requested review from langermank and removed request for a team September 26, 2024 21:51
@jonrohan jonrohan merged commit a615645 into main Sep 26, 2024
6 checks passed
@jonrohan jonrohan deleted the color_plugin_updates branch September 26, 2024 21:52
@primer-css primer-css mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant