fix: remove redundant mirror slash #10204
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where Node.js mirror URLs were constructed with duplicate slashes, causing 404 errors on mirror servers that don't handle double slashes gracefully. Since the nodeMirrorBaseUrl is guaranteed to end with a trailing slash (via the normalizeNodeMirror function), the extra slash when constructing the SHASUMS256.txt URL was redundant and problematic.
- Removed redundant leading slash when constructing the Node.js mirror integrity file URL
- Added changeset documenting the patch fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
env/node.resolver/src/index.ts |
Fixed URL construction in readNodeAssets to avoid double slash between base URL and version path |
.changeset/silver-geckos-hunt.md |
Added changeset entry documenting the bug fix for the duplicate slash issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zkochan
approved these changes
Nov 19, 2025
zkochan
pushed a commit
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the mirror base url already ends with a slash. if the internal mirror doesn't handle duplicate slashes, it will return a 404 error:
other impls:
pnpm/env/node.resolver/src/getNodeArtifactAddress.ts
Lines 24 to 27 in 60f3a05