feat(tests): add pytest-rerunfailures#3993
Merged
echoix merged 1 commit intooxsecurity:mainfrom Sep 12, 2024
Merged
Conversation
AlejandroSuero
requested review from
Kurt-von-Laven,
bdovaz,
echoix and
nvuillam
as code owners
echoix
approved these changes
Sep 12, 2024
Member
|
I love this PR :) |
Collaborator
|
It went into action in the auto update PR. Puppetlint test format fix got rerun 3 times and failed. Maybe using the default 5, or waiting more than 1 second between each retry might help (we have some tests that take a long time). But the real fix would be to have our tests non-flaky. That's just a patch |
Member
|
@echoix as failures are often due to race conditions, indeed wait for more than one second could be relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
pytest-rerunfailurestodev/requirementsentrypoint.shto use and installpytest-rerunfailuresrerunfailuresto.cspell.jsonReadiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance