Skip to content

fix(nuxt): deep merge extracted route meta #32887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 2 commits into from
Aug 18, 2025
Merged

fix(nuxt): deep merge extracted route meta #32887

danielroe merged 2 commits into from
Aug 18, 2025

Conversation

@BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented Aug 7, 2025

🔗 Linked issue

📚 Description

Nested properties in extracted meta are lost if the route meta already has a property/object with the same key.

@BobbieGoede BobbieGoede requested a review from danielroe as a code owner August 7, 2025 12:03
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Aug 7, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Aug 7, 2025 •
edited
Loading

Walkthrough

The PR adds a deep-merge of route meta using defu({}, routeMeta.meta, route.meta) in augmentPages instead of a shallow spread, so nested meta properties are merged recursively. The tests are updated to pass extraExtractionKeys including 'extracted', extend static and inline meta with an extracted object each, and assert the merged extracted meta contains both properties.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a02f5ed and f6feab0.

📒 Files selected for processing (1)
  • packages/nuxt/src/pages/utils.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/nuxt/src/pages/utils.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: codeql (javascript-typescript)
  • GitHub Check: build
  • GitHub Check: code
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 7, 2025 •
edited
Loading

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32887

nuxt

npm i https://pkg.pr.new/nuxt@32887

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32887

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32887

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32887

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32887

commit: f6feab0

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #32887 will not alter performance

Comparing BobbieGoede:fix/deep-merge-extracted-route-meta (f6feab0) with main (c5c1364)

Summary

✅ 10 untouched benchmarks

@danielroe danielroe merged commit 95d574a into nuxt:main Aug 18, 2025
81 of 83 checks passed
@github-actions github-actions bot mentioned this pull request Aug 18, 2025
Merged
danielroe pushed a commit that referenced this pull request Sep 2, 2025
@BobbieGoede @danielroe
fix(nuxt): deep merge extracted route meta (#32887)
0f3c945
@github-actions github-actions bot mentioned this pull request Sep 2, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

@huang-julien huang-julien huang-julien approved these changes

Assignees

No one assigned

Labels

4.x bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BobbieGoede @danielroe @huang-julien