Ignore empty stdout data when logging in verdaccio #16459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
Member
Author
|
Ok ignoring empty stdout is doing the job. The log when logging in to verdaccio are Verdaccio started
Logging in
stdout: Username:
Passing username...
stderr: npm notice Log in on http://0.0.0.0:4873/
stdout: Password:
Passing password...
stdout:
Ignoring empty stdout.
stdout:
Ignoring empty stdout.
stdout: Logged in on http://0.0.0.0:4873/.And ci is back to green |
krassowski
approved these changes
Jun 9, 2024
Member
krassowski
left a comment
krassowski
left a comment
There was a problem hiding this comment.
Thanks so much @fcollonval!
Member
|
@meeseeksdev please backport to 4.0.x |
Member
|
@meeseeksdev please backport to 3.6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 9, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 9, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 9, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 9, 2024
krassowski
pushed a commit
that referenced
this pull request
Jun 9, 2024
#16462) Co-authored-by: Frédéric Collonval <[email protected]>
krassowski
pushed a commit
that referenced
this pull request
Jun 9, 2024
#16461) Co-authored-by: Frédéric Collonval <[email protected]>
krassowski
pushed a commit
that referenced
this pull request
Jun 9, 2024
#16460) Co-authored-by: Frédéric Collonval <[email protected]>
Closed
krassowski
added a commit
that referenced
this pull request
Jun 19, 2024
#16463) Co-authored-by: Frédéric Collonval <[email protected]> Co-authored-by: Michał Krassowski <[email protected]>
ImpSy
pushed a commit
to spotinst/jupyterlab
that referenced
this pull request
Jan 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #16448
Code changes
Ignore empty stdout message when feeding prompt on verdaccio login.
User-facing changes
None
Backwards-incompatible changes
None