Skip to content

[3.6.x] Fix M1 install, declare node-gyp@^9.0.0 #15395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krassowski merged 4 commits into from
Nov 17, 2023
Merged

[3.6.x] Fix M1 install, declare node-gyp@^9.0.0 #15395

krassowski merged 4 commits into from
Nov 17, 2023

Conversation

@dlqqq
Copy link
Member

@dlqqq dlqqq commented Nov 12, 2023

References

Fixes #15394.

Code changes

  • Adds node-gyp@^9.0.0 in devDependencies.
  • Deduplicates dependencies via yarn yarn-deduplicate.

User-facing changes

None known.

Backwards-incompatible changes

None known. This should be a safe change because node-gyp is used infrequently for most users, as they typically use x86_64, which should always have prebuilds.

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Nov 12, 2023

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@dlqqq dlqqq added bug dependencies Pull requests that update a dependency file os:macos Issues specific to macOS operating system labels Nov 12, 2023
krassowski
krassowski reviewed Nov 12, 2023
View reviewed changes
@dlqqq
Copy link
Member Author

dlqqq commented Nov 12, 2023

@krassowski Thanks for adding me to the @jupyterlab org! I've added the labels. Will get the check-release workflow passing later.

@krassowski
Copy link
Member

krassowski commented Nov 12, 2023

Thanks! Yes, check_release should pass. I think there are a few tests with a pre-existing failures on 3.6.x: JS (js-testutils) and Linux (release_test, 3.10) so do not worry about them. Also, the visual regression tests are now blessed with multi-core processors by GitHub CI which means sometimes they fail as we did not adopt them yet to handle concurrent runs.

@krassowski krassowski added this to the 3.6.x milestone Nov 12, 2023
fcollonval
fcollonval requested changes Nov 13, 2023
View reviewed changes
@dlqqq
Copy link
Member Author

dlqqq commented Nov 13, 2023

@fcollonval Thanks for your input! Yes, I agree with this, although I maintain that there is a small risk involved. I'll update the PR shortly.

BTW, I filed an issue on node-gyp asking the maintainers to clarify what happens in major releases. I don't think all Node versions are supported; I believe the latest major version only supports whatever Node & Python versions were supported at the first release of that major version.

@dlqqq
Copy link
Member Author

dlqqq commented Nov 14, 2023

Updated the PR according to @fcollonval's feedback. CI is mostly passing, with a successful check-release, and the failures do not seem to be related.

cc @krassowski

fcollonval
fcollonval approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dlqqq

krassowski
krassowski approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dlqqq!

@krassowski krassowski merged commit 304f117 into jupyterlab:3.6.x Nov 17, 2023
@dlqqq dlqqq mentioned this pull request Nov 17, 2023
Closed
@dlqqq dlqqq deleted the fix-m1-install branch November 17, 2023 19:28
@krassowski krassowski mentioned this pull request Nov 17, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krassowski krassowski krassowski approved these changes

@fcollonval fcollonval fcollonval approved these changes

Assignees

@dlqqq dlqqq

Labels

bug dependencies Pull requests that update a dependency file os:macos Issues specific to macOS operating system

Projects

None yet

Milestone

3.6.x

Development

Successfully merging this pull request may close these issues.

3 participants

@dlqqq @krassowski @fcollonval