Install playwright browser in jupyterlab.browser_check #15117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
brichet
changed the title
Member
|
@meeseeksdev please backport to 4.0.x |
Member
|
@meeseeksdev please backport to 3.6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Sep 14, 2023
…b.browser_check
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
krassowski
pushed a commit
that referenced
this pull request
Sep 14, 2023
…check (#15118) Co-authored-by: Nicolas Brichet <[email protected]>
krassowski
pushed a commit
to krassowski/jupyterlab
that referenced
this pull request
Sep 14, 2023
) * Install playwright browser in jupyterlab.check_browser * Install all the browsers (cherry picked from commit c040532)
fcollonval
pushed a commit
that referenced
this pull request
Sep 25, 2023
…yterlab.browser_check) (#15122) * Install playwright browser in jupyterlab.browser_check (#15117) * Install playwright browser in jupyterlab.check_browser * Install all the browsers (cherry picked from commit c040532) * Pin node for docs job on 3.6.x --------- Co-authored-by: Nicolas Brichet <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playwright
v1.38.0does not download the browser at installation anymore.References
Fix #15116
Code changes
Install chrome browser in
jupyter.browser_checkUser-facing changes
None
Backwards-incompatible changes
None