Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing UnitOfPower to sensor #132352

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Add missing UnitOfPower to sensor #132352

merged 5 commits into from
Dec 5, 2024

Conversation

robinostlund
Copy link
Contributor

Proposed change

This PR #130089 is missing the units in homeassistant/components/sensor/const.py

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@robinostlund robinostlund requested a review from a team as a code owner December 5, 2024 09:00
@home-assistant
Copy link

home-assistant bot commented Dec 5, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensor can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sensor Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

epenet
epenet requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust also homeassistant/components/number/const.py

@home-assistant home-assistant bot marked this pull request as draft December 5, 2024 09:25
@home-assistant
Copy link

home-assistant bot commented Dec 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@epenet epenet added this to the 2024.12.1 milestone Dec 5, 2024
@robinostlund robinostlund marked this pull request as ready for review December 5, 2024 10:50
@home-assistant home-assistant bot requested a review from epenet December 5, 2024 10:50
epenet
epenet approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

gjohansson-ST
gjohansson-ST approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robinostlund 👍

@gjohansson-ST gjohansson-ST merged commit f4896f7 into home-assistant:dev Dec 5, 2024
64 checks passed
frenck pushed a commit that referenced this pull request Dec 6, 2024
@robinostlund @epenet @frenck
Add missing UnitOfPower to sensor (#132352)
92392ab 
* Add missing UnitOfPower to sensor

* Update homeassistant/components/sensor/const.py

Co-authored-by: epenet <[email protected]>

* adding to number

---------

Co-authored-by: epenet <[email protected]>
@frenck frenck mentioned this pull request Dec 6, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@epenet epenet epenet approved these changes

@gjohansson-ST gjohansson-ST gjohansson-ST approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed core integration: sensor Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.12.1
Development

Successfully merging this pull request may close these issues.
4 participants
@robinostlund @epenet @gjohansson-ST @frenck