Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tesla-fleet-api to 0.8.5 #132339

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Dec 5, 2024

Proposed change

Tesla added a new scope which isnt in the ENUM, so I need to bump Tesla Fleet API to fix #132298

Teslemetry/python-tesla-fleet-api@v0.8.4...v0.8.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor

epenet commented Dec 5, 2024

@Bre77 tests are failing could you take a look?

@epenet epenet marked this pull request as draft December 5, 2024 08:14
@epenet epenet changed the title Bump Tesla Fleet API to add new scope Bump tesla-fleet-api to 0.8.5 Dec 5, 2024
@Bre77 Bre77 marked this pull request as ready for review December 5, 2024 09:32
Comment on lines 36 to 37
"C": "Cybertruck",
"T": "Semi",
Copy link
Contributor

@epenet epenet Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for including this change in this PR?
I couldn't find anything related to the new models in the API bump, or a mention in the linked issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed those models were missing, so broke the perfect PR rule and put them in too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry but please remove them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I'll do a separate PR.

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bre77 👍

@gjohansson-ST
Copy link
Member

Test failures are not related

@gjohansson-ST gjohansson-ST merged commit 0aeb8f4 into home-assistant:dev Dec 5, 2024
60 of 61 checks passed
frenck pushed a commit that referenced this pull request Dec 6, 2024
@frenck frenck mentioned this pull request Dec 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: 'vehicle_location' is not a valid Scope
4 participants