Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated call to mimetypes.guess_type in CachingStaticResource #132299

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 4, 2024

Proposed change

This is the same change already made in aiohttp 3.11.10+ that we need for our cache layer as well.

https://docs.python.org/3/library/mimetypes.html#mimetypes.guess_type

Deprecated since version 3.13: Passing a file path instead of URL is soft deprecated. Use guess_file_type() for this.

These should have been changed to guess_file_type on Python 3.13 as guess_type expects a URL and guess_file_type expects a path. Its a soft deprecation so they still work but that may change in the future.

Note that there are quite a few more in the codebase as well, but we may want to wait on those until Python 3.12 support is dropped since they are more rare. The downside to calling guess_type is it will parse the file as a URL which is not cheap.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (http) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of http can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign http Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco marked this pull request as ready for review December 4, 2024 19:32
@bdraco bdraco requested a review from a team as a code owner December 4, 2024 19:32
@bdraco bdraco added this to the 2024.12.1 milestone Dec 6, 2024
@bdraco
Copy link
Member Author

bdraco commented Dec 6, 2024

Tagged since aiohttp 3.11.10 via #132441 has the same change.

@balloob balloob merged commit 88eb611 into dev Dec 6, 2024
64 checks passed
@balloob balloob deleted the guess_type_dep branch December 6, 2024 02:52
@frenck frenck mentioned this pull request Dec 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants