Update upload input values and logic
#1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelapwen
force-pushed
the
upload-input-values
branch
from
b6df6de to
39f1bc6
Compare
henrymercer
reviewed
Mar 22, 2023
Contributor
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
Some further changelog improvement suggestions!
henrymercer
reviewed
Mar 22, 2023
henrymercer
reviewed
Mar 23, 2023
Previously, failed runs' failed SARIF files were uploaded if the `upload` input was not `true`. Now, the failed SARIF files will be uploaded if the `upload` input was not `always`, `failure-only`, or `true`.
Previously, we uploaded results from the `analyze` step if the `upload` input was `true`. We now upload results if the `upload` input was set to `true` or `always`.
Co-authored-by: Henry Mercer <[email protected]>
Co-authored-by: Henry Mercer <[email protected]>
Co-authored-by: Henry Mercer <[email protected]>
angelapwen
force-pushed
the
upload-input-values
branch
from
46cf6c6 to
54e08db
Compare
henrymercer
approved these changes
Mar 23, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uploadinput to theanalyzeAction now accepts the following values:alwaysis the default value, which uploads the SARIF file to Code Scanning for successful and failed runs.failure-onlyis recommended for customers post-processing the SARIF file before uploading it to Code Scanning. This option uploads debugging information to Code Scanning for failed runs to improve the debugging experience.neveravoids uploading the SARIF file to Code Scanning even if the code scanning run fails. This is not recommended for external users since it complicates debugging.trueandfalseoptions will be interpreted asalwaysandfailure-onlyrespectively.Merge / deployment checklist