Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport bump of System.Configuration.ConfigurationManager and System.Threading.Tasks.Extensions #2856

Merged

Conversation

jnyrup
Copy link
Member

@jnyrup jnyrup commented Nov 30, 2024

Backport of #2673 and #2855 to v7.
See those two PRs for detailed analyses.

CC: @ViktorHofer @AArnott @jacekmlynek
Since you've previously been involved in package vs framework references.

Additional details:

In #2122 (comment) I experimented with referencing 6.9.0 and 6.10.0 as nuget packages from a net47 project and then comparing detailed MSBuild logs.
It showed how 6.10.0 no longer had conflicts between package and framework assemblies.

Doing that same comparison between main and this PR, the MSBuild log is now down from 90 to 0 occurrences of

Encountered conflict between 'Reference:'System.Foo' and 'Platform:System.Foo'

and now skips the running the build task AddFacadesToReferences

Comparing the bin/ folder of a net47 project that references Fluent Assertions via a nuget packages.
main:
image
image

PR:
image

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

ViktorHofer and others added 3 commits November 30, 2024 13:07
fluentassertions#2673 bumped from 4.4.0 -> 6.0.1, but 6.0.0 should be enough.
As a testing nuget we should pick the lowest possible version of a package to avoid that tests use a newer package than what is used in production.
@jnyrup jnyrup changed the title Jn/backport configuration manager Backport bump of System.Configuration.ConfigurationManager and System.Threading.Tasks.Extensions Nov 30, 2024
Copy link

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12096767877

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.365%

Totals Coverage Status
Change from base Build 12037968115: 0.0%
Covered Lines: 12933
Relevant Lines: 13169

💛 - Coveralls

@jnyrup jnyrup merged commit e0f4504 into fluentassertions:main Nov 30, 2024
5 checks passed
@jnyrup jnyrup deleted the jn/backport_configuration_manager branch November 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants