Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section highlighting for better navigation #2807

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Add section highlighting for better navigation #2807

merged 2 commits into from
Nov 9, 2024

Conversation

sentemon
Copy link
Contributor

@sentemon sentemon commented Nov 8, 2024 •
edited
Loading

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@sentemon sentemon mentioned this pull request Nov 8, 2024
Closed
@dennisdoomen
Copy link
Member

That looks pretty neat. Wouldn't it be nicer that if you select a section, only the relevant page is highlighted?

image

@sentemon
Copy link
Contributor Author

sentemon commented Nov 9, 2024

This means that the user is in the "Documentation" section, but if you select a specific section, only it will be highlighted
Screenshot 2024-11-09 at 10 22 13

@dennisdoomen
Copy link
Member

Isn't it nicer that then only the Documentation section is highlighted?

@sentemon
Copy link
Contributor Author

sentemon commented Nov 9, 2024

It seems to me that I did what you wanted, but honestly, I’m already tired of dealing with these styles - after all, I’m a backend developer, not a magician 😆

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@dennisdoomen
Copy link
Member

It seems to me that I did what you wanted, but honestly, I’m already tired of dealing with these styles - after all, I’m a backend developer, not a magician

Yeah, totally got that. Was just sharing some thoughts.

@dennisdoomen dennisdoomen merged commit d4acc9d into fluentassertions:master Nov 9, 2024
2 checks passed
@dennisdoomen
Copy link
Member

But thanks for your effort.

@sentemon sentemon deleted the feat/add-section-highlighting branch November 9, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentemon @dennisdoomen