Upgrade cookie signature #5833
Merged
Upgrade cookie signature #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
wesleytodd
approved these changes
Aug 17, 2024
|
@wesleytodd do you want me to rebase it to update with latest pushes in the master? Edit: already did 🙂 |
IamLizu
force-pushed
the
upgrade-cookie-signature
branch
from
e6d3a58 to
e52abcd
Compare
wesleytodd
reviewed
Aug 23, 2024
package.json
Outdated
| @@ -33,7 +33,7 @@ | |||
| "content-disposition": "0.5.4", | |||
| "content-type": "~1.0.4", | |||
| "cookie": "0.6.0", | |||
| "cookie-signature": "1.0.6", | |||
| "cookie-signature": "1.2.1", | |||
There was a problem hiding this comment.
Can we open it up with ^? We ahve been doing that as we update these in the v5 branch.
There was a problem hiding this comment.
Thank you for pointing out the caret.
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with the expressjs/discussions#256, we are upgrading the
cookie-signaturefrom 1.0.6 to 1.2.1.Notes
Since all items listed in list are already landed, this PR