-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tty-table dependency #1390
Conversation
🦋 Changeset detectedLatest commit: e063e58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
+ Coverage 80.95% 80.99% +0.03%
==========================================
Files 54 54
Lines 2211 2210 -1
Branches 652 657 +5
==========================================
Hits 1790 1790
+ Misses 417 416 -1
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Looks like |
I've discussed with @jakebailey and @benmccann of some alternative table libraries:
Other libraries like |
In a sense, the only thing that |
It works for me, I think. Since a lot of changesets can be related to any particular release, I wonder if this should be a bullet~ list or just a comma-delimited list. None of them is perfect as it all depends on how many packages, changesets, etc u have... Let's just roll with what u have above. |
The
tty-table
dependency is only used forchangeset status --verbose
. The dependency has a very big dependency graph of 115 transitive dependencies with many polyfill packages.This PR re-implements a simpler table formatting manually to remove
tty-table
, as I can't find a similar table printing table that would suffice the current requirements. I don't think the large dependency footprint is worth keeping it around either.The main difference is that this PR's implementation does not shrink the table on small console widths, but I think it's a fine tradeoff for now. The shrinking behaviour also sometimes cuts off package names and changeset paths.
Before:
After:
Previous refactor of table form
*Now updated as a list display from #1390 (comment)