Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed changeset status combined with ignored and non-versionable private packages #1354

Merged
merged 3 commits into from
May 17, 2024
Merged

Fixed changeset status combined with ignored and non-versionable private packages #1354

merged 3 commits into from
May 17, 2024

Conversation

Andarist
Copy link
Member

No description provided.

@Andarist Andarist requested a review from emmatown May 16, 2024 21:56
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 428daa5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 16, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Andarist Andarist mentioned this pull request May 16, 2024
Merged
jakebailey
jakebailey approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With no knowledge of the codebase, this seems correct, though it does seem like anywhere getChangedPackagesSinceRef is used would need this exact filtering, right? More or less I'm looking for a way to just tell changesets to never worry about private packages period.

@Andarist
Copy link
Member Author

though it does seem like anywhere getChangedPackagesSinceRef is used would need this exact filtering, right?

yeah, I just made sure that it's the case. It turns out that we had almost the same filtering in another place. I didn't make the change in getChangedPackagesSinceRef itself though since that's a lower-level util. It has no notion of Changesets today.

@Andarist Andarist merged commit 69be7dc into main May 17, 2024
1 check passed
@Andarist Andarist deleted the fix/changeset-status-cases branch May 17, 2024 08:29
@github-actions github-actions bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown approved these changes

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andarist @jakebailey @emmatown