Improve @babel/parser error typing
#17521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Bug Fix 🐛
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60024 |
|
commit: |
| parser.state.strict = true; | ||
| } | ||
| return parser.getExpression() as unknown as ParseResult<Expression>; | ||
| return parser.getExpression() as ParseResult<Expression>; |
Member
There was a problem hiding this comment.
ParseResult<Expression> doesn't declare properties like .comments correctly, could you improve it by the way? :)
JLHwung
force-pushed
the
improve-babel-parser-error-typing
branch
from
448e3f5 to
00d723e
Compare
liuxingbaoyu
force-pushed
the
improve-babel-parser-error-typing
branch
from
a8305f6 to
4c8f0b0
Compare
JLHwung
force-pushed
the
improve-babel-parser-error-typing
branch
from
4c8f0b0 to
b76b6ba
Compare
JLHwung
commented
Sep 26, 2025
JLHwung
commented
Sep 26, 2025
liuxingbaoyu
approved these changes
Sep 26, 2025
JLHwung
force-pushed
the
improve-babel-parser-error-typing
branch
from
a38d6f9 to
fbbed6f
Compare
JLHwung
force-pushed
the
improve-babel-parser-error-typing
branch
from
fbbed6f to
dfb68b6
Compare
nicolo-ribaudo
approved these changes
Oct 3, 2025
This was referenced Oct 23, 2025
This was referenced Nov 27, 2025
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we create the
ParseErrorfrom the genericParseErrorinterface, which provides complete parse error properties.The
File -> ParseResult<File>casting is also moved to the top levelparse()method.