fix: ensure scope.push register in anonymous fn #17504
Merged
+89
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Bug Fix 🐛
JLHwung
commented
Sep 5, 2025
|
|
||
| function isAnonymousFunctionExpression( | ||
| path: NodePath, | ||
| ): path is NodePath<t.FunctionExpression | t.ArrowFunctionExpression> { |
Contributor
Author
There was a problem hiding this comment.
The predicate here also converts NodePath<A> | NodePath<B> to NodePath<A | B> such that path.pushContainer can work. This is a bit unfortunate as we have already made it distributive.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59904 |
|
commit: |
nicolo-ribaudo
approved these changes
Sep 5, 2025
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope.pushmay register binding to parameter when the function is a named function expression.Spot this issue when working on #17503. Previously we checked
.nameproperty, which should have been.id.