Skip to content

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jan 22, 2025

Q                       A
Fixed Issues? Incorrect ranges of the method value node in estree mode.
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we call the resetStartLocationFromNode method which respects the ranges option. Added a new test since this was not covered in our test suites.

@JLHwung JLHwung added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jan 22, 2025
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58620

@JLHwung JLHwung merged commit 09f985d into babel:main Jan 22, 2025
55 checks passed
@JLHwung JLHwung deleted the fix-estree-method-start branch January 22, 2025 18:08
laine-hallot pushed a commit to laine-hallot/uwu-parser that referenced this pull request Mar 31, 2025
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 24, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants