Allow the dynamic import.defer() form of import defer
#17011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58438 |
liuxingbaoyu
reviewed
Dec 6, 2024
Comment on lines
+11
to
+14
| language/import/import-defer/errors/resolution-error/import-defer-of-missing-module-fails.js(default) | ||
| language/import/import-defer/errors/resolution-error/import-defer-of-missing-module-fails.js(strict mode) | ||
| language/import/import-defer/errors/syntax-error/import-defer-of-syntax-error-fails.js(default) | ||
| language/import/import-defer/errors/syntax-error/import-defer-of-syntax-error-fails.js(strict mode) |
Member
There was a problem hiding this comment.
We can probably ignore the resolution error.
Member
There was a problem hiding this comment.
Yeah, we should update our test262 runner because we only do the parsing phase.
Member
There was a problem hiding this comment.
Oh but we are failing to parse those files?
Member
There was a problem hiding this comment.
It's a bug in the tests
liuxingbaoyu
approved these changes
Dec 6, 2024
nicolo-ribaudo
changed the title
import.defer() form of import defer
nicolo-ribaudo
added
the
PR: Spec Compliance 👓
JLHwung
approved these changes
Dec 6, 2024
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update test262 to eefc5cf367b999768445432e167606fd1acf1734.