[estree] Adjust the start loc of class methods with type params #16996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58442 |
JLHwung
approved these changes
Dec 4, 2024
nicolo-ribaudo
force-pushed
the
estree-method-type-params-loc
branch
from
c12d3be to
f5c465a
Compare
liuxingbaoyu
approved these changes
Dec 6, 2024
nicolo-ribaudo
changed the title
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2I noticed this as one of the differences with typescript-eslint. We move the type arguments from the class member to the FunctionExpression, but we forgot to also adjust the location.
The test is weirdly formatted so that you can easily see that now the FunctionExpression starts at column 0.