[flake8-bugbear] Mark the fix for unreliable-callable-check as always unsafe (B004)
#20318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDrokin117
changed the title
flake8-bugbear] unreliable-callable-check always marked as unsafe (B004)flake8-bugbear] unreliable-callable-check always marked as unsafe (B004)
Contributor
|
IDrokin117
force-pushed
the
fix/ruff-20282
branch
from
b764614 to
a3c30b6
Compare
IDrokin117
force-pushed
the
fix/ruff-20282
branch
from
a3c30b6 to
9c6ce3c
Compare
ntBre
approved these changes
Sep 12, 2025
crates/ruff_linter/src/rules/flake8_bugbear/rules/unreliable_callable_check.rs
Outdated
Show resolved
Hide resolved
ntBre
changed the title
flake8-bugbear] unreliable-callable-check always marked as unsafe (B004)flake8-bugbear] Mark the fix for unreliable-callable-check as always unsafe (B004)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #20282
Makes the rule fix always unsafe, because the replacement may not be semantically equivalent to the original expression, potentially changing the behavior of the code.
Updated docstring with examples.
Test Plan