Page MenuHomePhabricator

Performance IssueTag
ActivePublic

Members (4)

Watchers (3)

Details

Description

Generic tag for current issues that are causing slow server responses or slow/costly client-side payloads.

This is a form of Technical-Debt (use that workboard).

(For the workboard of the Performance Team, see Performance-Team.)

Recent Activity

Yesterday

Pppery moved T379688: Special:ListFiles should format comments in batch to improve performance on generating the special page from To triage to Multimedia-related on the MediaWiki-Special-pages board.
Thu, Nov 14, 6:40 PM · Patch-For-Review, Performance Issue, MediaWiki-Special-pages
Peter added a comment to T378919: JavaScript increase desktop and mobile 2024-10-28 .

I've have some input:

Thu, Nov 14, 12:15 PM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog
AbbanWMDE added a comment to T378919: JavaScript increase desktop and mobile 2024-10-28 .

Here's desktop and mobile banners where we execute our entry point code but only mount the Vuejs banner component after the 7.5 second timeout:

Thu, Nov 14, 12:06 PM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog
CorinnaHillebrand_WMDE moved T378919: JavaScript increase desktop and mobile 2024-10-28 from Ready for Work to In Progress / Deployment (max. 4 tasks) on the WMDE-FUN-Funban-2024 board.
Thu, Nov 14, 9:17 AM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog

Wed, Nov 13

gabriel-wmde added a comment to T378919: JavaScript increase desktop and mobile 2024-10-28 .

Good news everyone! I thought about this a bit more and ran another test to confirm/falsify my hypothesis of "all that JavaScript execution increases the TBT". I created a test banner where I wrapped our current banner in a 7.5 second timeout. It'll still be loaded by CentralNotice, increasing the Page Transfer Size (which we could avoid for repeat visitors if CN supported sending HTTP cache headers for banners, but that's outside of WMDE's control and needs a separate ticket and discussion in the WMF team that maintains Central Notice), it'll still parse the JavaScript, but the initialization code for the banner would be run outside the "measuring window" (that measures the "Time To Interactive" and then some). The results of the test look very promising: The TBT went down by almost 100ms and is now at pre-banner levels. See for yourself in the comparison of the regular banner with the timeout-banner as the baseline. The cpu.lastLongTask and cpu.totalDuration show even greater improvements. You can of course also look at the individual result of the banner with timeout

Wed, Nov 13, 9:00 PM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog
MusikAnimal added a comment to T286270: CodeMirror does not set a default for "usecodemirror" preference, causing user_properties bloat.

I'm going to wait to observe changes in data as this is rolled out, before closing again.

Wed, Nov 13, 5:12 PM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Community-Tech (CommTech-Sprint-6), MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Performance Issue, MediaWiki-extensions-CodeMirror
ReleaseTaggerBot added a project to T286270: CodeMirror does not set a default for "usecodemirror" preference, causing user_properties bloat: MW-1.44-notes (1.44.0-wmf.4; 2024-11-19).
Wed, Nov 13, 9:00 AM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Community-Tech (CommTech-Sprint-6), MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Performance Issue, MediaWiki-extensions-CodeMirror
Peter added a comment to T378919: JavaScript increase desktop and mobile 2024-10-28 .

Hi @gabriel-wmde thanks for the investigation. I agree with you that it doesn't look like quick fix and I like your idea that we all need to work together.

Wed, Nov 13, 8:46 AM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog
gerritbot added a comment to T286270: CodeMirror does not set a default for "usecodemirror" preference, causing user_properties bloat.

Change #1090719 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] extension.json: set default user option for usecodemirror-colorblind

https://gerrit.wikimedia.org/r/1090719

Wed, Nov 13, 8:45 AM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Community-Tech (CommTech-Sprint-6), MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Performance Issue, MediaWiki-extensions-CodeMirror
MusikAnimal reopened T286270: CodeMirror does not set a default for "usecodemirror" preference, causing user_properties bloat as "Open".

Re-opening as the exact same issue, except for the usecodemirror-colorblind preference:

Wed, Nov 13, 7:52 AM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Community-Tech (CommTech-Sprint-6), MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Performance Issue, MediaWiki-extensions-CodeMirror
gerritbot added a comment to T286270: CodeMirror does not set a default for "usecodemirror" preference, causing user_properties bloat.

Change #1090719 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] extension.json: set default user option for usecodemirror-colorblind

https://gerrit.wikimedia.org/r/1090719

Wed, Nov 13, 7:08 AM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Community-Tech (CommTech-Sprint-6), MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Patch-For-Review, Performance Issue, MediaWiki-extensions-CodeMirror

Tue, Nov 12

gerritbot added a project to T379688: Special:ListFiles should format comments in batch to improve performance on generating the special page: Patch-For-Review.
Tue, Nov 12, 10:06 PM · Patch-For-Review, Performance Issue, MediaWiki-Special-pages
gerritbot added a comment to T379688: Special:ListFiles should format comments in batch to improve performance on generating the special page.

Change #1052155 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] specials: Use batch to format comments on Special:ListFiles

https://gerrit.wikimedia.org/r/1052155

Tue, Nov 12, 10:06 PM · Patch-For-Review, Performance Issue, MediaWiki-Special-pages
Umherirrender created T379688: Special:ListFiles should format comments in batch to improve performance on generating the special page.
Tue, Nov 12, 10:05 PM · Patch-For-Review, Performance Issue, MediaWiki-Special-pages
gabriel-wmde added a comment to T378919: JavaScript increase desktop and mobile 2024-10-28 .

Thanks everyone for the support.

Tue, Nov 12, 6:52 PM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog
Jdforrester-WMF moved T362271: Make wikilambda_fetch cacheable from Backlog to Engineering Backlog on the Abstract Wikipedia team board.
Tue, Nov 12, 5:00 PM · MW-1.43-notes (1.43.0-wmf.4; 2024-05-07), Performance Issue, Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team
gabriel-wmde claimed T378919: JavaScript increase desktop and mobile 2024-10-28 .
Tue, Nov 12, 3:07 PM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog
NBaca-WMF updated subscribers of T378919: JavaScript increase desktop and mobile 2024-10-28 .

@WMDE-leszek and @gabriel-wmde - There is no current assignee for this ticket and no priority set. Given the issue lies in code you all maintain, I would request you set an owner and assignee to clarify next steps here. Please let me know if you have concerns with this, but given the magnitude of the performance impact I think it's important to have clear ownership and explicit priority. Thanks

Tue, Nov 12, 2:45 PM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog

Sun, Nov 10

Reedy updated the task description for T379482: Increase the common passwords list to 1M entries.
Sun, Nov 10, 2:43 AM · Patch-For-Review, Performance Issue, CommonPasswords
Reedy triaged T379482: Increase the common passwords list to 1M entries as Low priority.
Sun, Nov 10, 2:40 AM · Patch-For-Review, Performance Issue, CommonPasswords
gerritbot added a project to T379482: Increase the common passwords list to 1M entries: Patch-For-Review.
Sun, Nov 10, 2:36 AM · Patch-For-Review, Performance Issue, CommonPasswords
gerritbot added a comment to T379482: Increase the common passwords list to 1M entries.

Change #868769 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/CommonPasswords@master] WIP: Increase password list from 100K to 1M

https://gerrit.wikimedia.org/r/868769

Sun, Nov 10, 2:36 AM · Patch-For-Review, Performance Issue, CommonPasswords
Reedy created T379482: Increase the common passwords list to 1M entries.
Sun, Nov 10, 2:36 AM · Patch-For-Review, Performance Issue, CommonPasswords

Fri, Nov 8

NBaca-WMF added a comment to T378919: JavaScript increase desktop and mobile 2024-10-28 .

Hi all -
Firstly, thank you @Peter for catching and filing this issue, and providing further clarity! And thank you @gabriel-wmde for looking into this.

Fri, Nov 8, 5:06 PM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog
Peter added a comment to T378919: JavaScript increase desktop and mobile 2024-10-28 .

Hi @gabriel-wmde , sorry for being slow on this. Ok, let me explain the performance tests:

Fri, Nov 8, 4:05 PM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog
Esanders added a comment to T130142: newFromDocumentInsertion transactions always replace the entire internal list.

The above patch will simplify transactions when the incoming document has no references (most image inerstions, most wikitext pastes). Simplifying transctions which involve references will be more complicated.

Fri, Nov 8, 2:58 PM · Patch-For-Review, Performance Issue, Technical-Debt, VisualEditor-DataModel, VisualEditor
gerritbot added a project to T130142: newFromDocumentInsertion transactions always replace the entire internal list: Patch-For-Review.
Fri, Nov 8, 2:58 PM · Patch-For-Review, Performance Issue, Technical-Debt, VisualEditor-DataModel, VisualEditor
gerritbot added a comment to T130142: newFromDocumentInsertion transactions always replace the entire internal list.

Change #1088581 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] newFromDocumentInsertion: Skip list replacement when new list is empty

https://gerrit.wikimedia.org/r/1088581

Fri, Nov 8, 2:57 PM · Patch-For-Review, Performance Issue, Technical-Debt, VisualEditor-DataModel, VisualEditor
gabriel-wmde added a comment to T378919: JavaScript increase desktop and mobile 2024-10-28 .

Thanks for the comment, @awight. Good idea to load banner asynchronously, I agree with your assessment and like your proposal.

Fri, Nov 8, 2:28 PM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog
awight added projects to T378919: JavaScript increase desktop and mobile 2024-10-28 : MediaWiki-extensions-CentralNotice, Performance Issue.
Fri, Nov 8, 7:11 AM · Performance Issue, MediaWiki-extensions-CentralNotice, WMDE-FUN-Funban-2024, WMDE-FUN-Team, WMDE-Fundraising-Tech, Web-Team-Backlog

Tue, Nov 5

Physikerwelt added a subtask for T54777: user_properties table bloat: T166369: Migrate old Math options to current ones or delete them from the database.
Tue, Nov 5, 8:06 AM · Wikimedia-maintenance-script-run, Performance Issue, WMF-General-or-Unknown

Mon, Nov 4

Od1n added a comment to T357199: Could we optimize Lua environment setup to improve {{#invoke:}} performance?.

Another track for improvement would be to implement some lazy-loading. It is a shame to clone everything when we only use a fraction of the available librairies.

Mon, Nov 4, 6:31 PM · Performance Issue, MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), Scribunto
Maintenance_bot removed a project from T359003: Optimize phan-taint-check speed, 2024 edition: Patch-For-Review.
Mon, Nov 4, 2:30 PM · Performance Issue, User-Daimona, phan-taint-check-plugin
gerritbot added a comment to T359003: Optimize phan-taint-check speed, 2024 edition.

Change #1086572 merged by jenkins-bot:

[mediawiki/tools/phan/SecurityCheckPlugin@master] Make most remaining objects immutable

https://gerrit.wikimedia.org/r/1086572

Mon, Nov 4, 2:13 PM · Performance Issue, User-Daimona, phan-taint-check-plugin
gerritbot added a project to T359003: Optimize phan-taint-check speed, 2024 edition: Patch-For-Review.
Mon, Nov 4, 12:27 AM · Performance Issue, User-Daimona, phan-taint-check-plugin
gerritbot added a comment to T359003: Optimize phan-taint-check speed, 2024 edition.

Change #1086572 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/phan/SecurityCheckPlugin@master] Make most remaining objects immutable

https://gerrit.wikimedia.org/r/1086572

Mon, Nov 4, 12:27 AM · Performance Issue, User-Daimona, phan-taint-check-plugin

Sat, Nov 2

Aklapper renamed T378762: Edits seem to be much slower in REL1_43 from Edits seem to be much slower to Edits seem to be much slower in REL1_43.
Sat, Nov 2, 8:00 PM · Performance Issue, MediaWiki-Core-DeferredUpdates, User-Physikerwelt, NFDI-Germany
Aklapper edited projects for T378762: Edits seem to be much slower in REL1_43, added: MediaWiki-Core-DeferredUpdates, Performance Issue; removed MW-1.43-release.
Sat, Nov 2, 1:47 PM · Performance Issue, MediaWiki-Core-DeferredUpdates, User-Physikerwelt, NFDI-Germany

Fri, Nov 1

Xqt closed T111479: Timeout in testApiMethods calling mediawiki_messages as Resolved.
Fri, Nov 1, 5:54 PM · Performance Issue, All-and-every-Wiktionary, MediaWiki-Action-API, Pywikibot, Pywikibot-tests

Thu, Oct 31

MSantos moved T369898: Reduce the number of resource_change and resource_purge events emitted due to template changes from Backlog to Later on the Content-Transform-Team board.
Thu, Oct 31, 2:25 PM · Content-Transform-Team, Essential-Work, MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), serviceops, Performance Issue, MediaWiki-Engineering, MediaWiki-Core-HTTP-Cache, ChangeProp

Sat, Oct 26

Pppery moved T199538: Display the number of the list entries on special pages with lists from To triage to Multiple special pages on the MediaWiki-Special-pages board.
Sat, Oct 26, 4:35 PM · patch-welcome, Performance Issue, MediaWiki-Special-pages, Wikimania-Hackathon-2018
Pppery moved T55852: Special:PagesWithProp should use &continue=<last primary key> style paging instead of &offset=<last count> from To triage to Other special pages on the MediaWiki-Special-pages board.
Sat, Oct 26, 4:29 PM · Performance Issue, MediaWiki-Special-pages
Pppery moved T275667: On non-english content language wikis the use of Special:Redirect/logid results in unneeded server redirects from To triage to Other special pages on the MediaWiki-Special-pages board.
Sat, Oct 26, 4:22 PM · MediaWiki-Special-pages, Performance Issue

Thu, Oct 24

Reedy edited projects for T378137: Increase maximum allowed highlighting time, added: MediaWiki-extensions-CodeMirror, Performance Issue; removed SyntaxHighlight.
Thu, Oct 24, 8:04 PM · Performance Issue
Pppery removed projects from T378137: Increase maximum allowed highlighting time: MediaWiki-extensions-CodeMirror, Community-Tech.
Thu, Oct 24, 8:02 PM · Performance Issue

Wed, Oct 23

tstarling added a comment to T353891: https://lists.wikimedia.org is often slow to load.

The slow request was

Wed, Oct 23, 4:59 AM · Upstream, SRE, Performance Issue, Wikimedia-Mailing-lists
tstarling added a comment to T353891: https://lists.wikimedia.org is often slow to load.

The MW installer has a feature allowing the user to check a box to subscribe to mediawiki-announce. I tried to test it, since I'm doing maintenance on the client code. It timed out in the client, but the Apache logs on lists1004 show it completing successfully after 56 seconds. I got the confirmation email. I did another two requests with the same email and they each took about 57 seconds.

Wed, Oct 23, 3:06 AM · Upstream, SRE, Performance Issue, Wikimedia-Mailing-lists

Sun, Oct 20

Pppery moved T175088: Re-assess which "expensive" query pages are run on cron for Wikimedia sites from Analysis / under discussion to Blocked on SRE on the Wikimedia-Site-requests board.
Sun, Oct 20, 2:30 AM · Performance Issue, Wikimedia-Site-requests
Pppery moved T106640: Choose a sensible set of thumbnail sizes for Special:Preferences from Analysis / under discussion to Backlog on the Wikimedia-Site-requests board.
Sun, Oct 20, 2:19 AM · serviceops, Wikimedia-Site-requests, Performance Issue, Multimedia
Pppery updated the task description for T47476: Enable Unicode normalization for Malayalam on Wikimedia Wikis.
Sun, Oct 20, 2:19 AM · Malayalam-Sites, Performance Issue, I18n, Wikimedia-Site-requests