Page MenuHomePhabricator
Create Task
Maniphest T380455

Run revalidateLinkRecommendations.php for wikis with more than 25 excluded sections
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

As discovered in T380329, up until today, the Add Link API was ignoring some excluded sections if more than 25 of them were excluded. That means we should run revalidateLinkRecommendations.php for (at least) those wikis.

In addition to that, this is probably a good opportunity to review the list of excluded sections. Considering the ignored sections were not causing a noticeable problem, maybe there is something that should be cleaned up.

Target wikis for validation with ambassadors

  • enwiki
  • eswiki
  • frwiki
  • ...
  • rest of wikis without validation

Related Objects

Event Timeline

Urbanecm_WMF created this task.Nov 21 2024, 10:49 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 21 2024, 10:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF mentioned this in T380329: az.wikipedia: Add Link tasks are completed while violating excludedSections configuration.Nov 21 2024, 10:52 AM
Urbanecm_WMF moved this task from Inbox to Up Next on the Growth-Team board.Nov 22 2024, 8:54 PM
Sgs updated the task description. (Show Details)Tue, Nov 26, 5:15 PM
Restricted Application added a subscriber: Nemoralis. · View Herald TranscriptTue, Nov 26, 5:15 PM
Sgs set the point value for this task to 2.Tue, Nov 26, 5:16 PM
Sgs moved this task from Up Next to Current Sprint on the Growth-Team board.Tue, Nov 26, 5:53 PM
Sgs edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Urbanecm_WMF updated the task description. (Show Details)Wed, Nov 27, 11:55 AM
Urbanecm_WMF updated the task description. (Show Details)
Urbanecm_WMF claimed this task.Wed, Dec 4, 5:22 PM

Consensus from standup: We should run the script without looking at individual configuration, assuming community configuration has whatever the community prefers. Will run the script on all wikis then.

Nemoralis added a project: User-notice.EditedWed, Dec 4, 5:34 PM

We discussed this with Urbanecm on IRC. If the number of sections in the "List of excluded sections from the Add link task" (Special:CommunityConfiguration/GrowthSuggestedEdits) exceeds 25, sections beyond 25 are not excluded due to an undocumented limit. We think that wikis should be informed about this. This issue was identified and resolved in T380329: az.wikipedia: Add Link tasks are completed while violating excludedSections configuration

Stashbot added a comment.Thu, Dec 5, 11:23 PM

Mentioned in SAL (#wikimedia-operations) [2024-12-05T23:23:54Z] <urbanecm> Start revalidateLinkRecommendations.php for Add Link-enabled wikis via mwscript-k8s (T380455)

• Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Thu, Dec 5, 11:31 PM
Stashbot added a comment.Fri, Dec 6, 12:19 AM

Mentioned in SAL (#wikimedia-operations) [2024-12-06T00:19:36Z] <urbanecm> Delete previously-started mwscript-k8s instances of revalidateLinkRecommendations.php (T380455)

Stashbot added a comment.Fri, Dec 6, 12:19 AM

Mentioned in SAL (#wikimedia-operations) [2024-12-06T00:19:49Z] <urbanecm> mwmaint2002: foreachwikiindblist growthexperiments extensions/GrowthExperiments/maintenance/revalidateLinkRecommendations.php --all --verbose # T380455

Urbanecm_WMF added a comment.Mon, Dec 9, 9:18 AM

Script is still running, currently at fiwiki.

Michael subscribed.Tue, Dec 10, 10:10 AM

Note: we might be seeing the effects of this script in this dashboard: https://grafana.wikimedia.org/d/fe251f4f-f6cf-4010-8d78-5f482255b16f/cirrussearch-update-pipeline-weighted-tags?orgId=1&var-tag_prefix=recommendation_link&var-search_cluster_site=codfw&var-search_cluster=consumer-search&from=now-7d&to=now&refresh=1m

Urbanecm_WMF moved this task from Incoming to Blocked / Needs Work on the Growth-Team (Current Sprint) board.Tue, Dec 10, 5:42 PM
• Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Thu, Dec 12, 6:14 PM
Pppery moved this task from Backlog to WMF Prod on the Wikimedia-maintenance-script-run board.Fri, Dec 13, 2:08 AM
Urbanecm_WMF added a comment.Mon, Dec 16, 1:05 PM

Still running, currently at yiwiki.

Urbanecm_WMF closed this task as Resolved.Mon, Dec 16, 5:19 PM

Finished. Logs are at https://people.wikimedia.org/~urbanecm/growth-team-internal/T380455.log.bz2.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits