Page MenuHomePhabricator
Create Task
Maniphest T341754

Deploy wikidiff2 paragraph split detection
Closed, ResolvedPublic
Actions

Description

We would like users to benefit from our work on diff split detection.

Details

SubjectRepoBranchLines +/-
wikidiff2: set maxSplitSize = 10 by defaultoperations/mediawiki-configmaster+1 -5
Include $wgWikidiff2Options in the diff cache keymediawiki/coremaster+28 -2
wikidiff2: set maxSplitSize = 10 on group1 wikisoperations/mediawiki-configmaster+4 -0
Set wikidiff2 maxSplitSize = 10 on group0 wikisoperations/mediawiki-configmaster+7 -0
Add support for wikidiff2_multi_format_diff()mediawiki/coremaster+178 -20
Customize query in gerrit

Related Objects

Event Timeline

tstarling created this task.Jul 13 2023, 2:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2023, 2:22 AM
gerritbot added a comment.Jul 13 2023, 2:29 AM

Change 936135 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Add support for wikidiff2_multi_format_diff()

https://gerrit.wikimedia.org/r/936135

gerritbot added a project: Patch-For-Review.Jul 13 2023, 2:29 AM
TheresNoTime moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jul 19 2023, 1:58 PM
TheDJ subscribed.Jul 19 2023, 2:03 PM
HMonroy edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.Jul 26 2023, 6:21 PM
gerritbot added a comment.Jul 31 2023, 11:54 AM

Change 936135 merged by jenkins-bot:

[mediawiki/core@master] Add support for wikidiff2_multi_format_diff()

https://gerrit.wikimedia.org/r/936135

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 12:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 31 2023, 1:00 PM
tstarling updated the task description. (Show Details)Aug 8 2023, 11:32 AM
gerritbot added a comment.Aug 11 2023, 4:02 AM

Change 947986 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[operations/mediawiki-config@master] Set wikidiff2 maxSplitSize = 10 on group0 wikis

https://gerrit.wikimedia.org/r/947986

gerritbot added a project: Patch-For-Review.Aug 11 2023, 4:02 AM
gerritbot added a comment.Aug 15 2023, 11:14 PM

Change 947986 merged by jenkins-bot:

[operations/mediawiki-config@master] Set wikidiff2 maxSplitSize = 10 on group0 wikis

https://gerrit.wikimedia.org/r/947986

Stashbot added a comment.Aug 15 2023, 11:26 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-15T23:26:30Z] <hmonroy@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Set wikidiff2 maxSplitSize = 10 on group0 wikis T341754 (duration: 07m 39s)

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2023, 11:30 PM
HMonroy updated the task description. (Show Details)Aug 15 2023, 11:42 PM
gerritbot added a comment.Aug 18 2023, 12:00 AM

Change 950049 had a related patch set uploaded (by HMonroy; author: HMonroy):

[operations/mediawiki-config@master] wikidiff2: set maxSplitSize = 10 on group1 wikis

https://gerrit.wikimedia.org/r/950049

gerritbot added a project: Patch-For-Review.Aug 18 2023, 12:00 AM
TheresNoTime assigned this task to HMonroy.Aug 22 2023, 11:25 AM
TheresNoTime moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.
gerritbot added a comment.Aug 22 2023, 11:54 PM

Change 951590 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Include $wgWikidiff2Options in the diff cache key

https://gerrit.wikimedia.org/r/951590

gerritbot added a comment.Aug 23 2023, 8:12 PM

Change 950049 merged by jenkins-bot:

[operations/mediawiki-config@master] wikidiff2: set maxSplitSize = 10 on group1 wikis

https://gerrit.wikimedia.org/r/950049

Stashbot added a comment.Aug 23 2023, 8:12 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-23T20:12:58Z] <hmonroy@deploy1002> Started scap: Backport for [[gerrit:950049|wikidiff2: set maxSplitSize = 10 on group1 wikis (T341754)]]

Stashbot added a comment.Aug 23 2023, 8:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-23T20:14:32Z] <hmonroy@deploy1002> hmonroy: Backport for [[gerrit:950049|wikidiff2: set maxSplitSize = 10 on group1 wikis (T341754)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Aug 23 2023, 8:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-23T20:23:22Z] <hmonroy@deploy1002> Finished scap: Backport for [[gerrit:950049|wikidiff2: set maxSplitSize = 10 on group1 wikis (T341754)]] (duration: 10m 24s)

gerritbot added a comment.Aug 23 2023, 9:22 PM

Change 951590 merged by jenkins-bot:

[mediawiki/core@master] Include $wgWikidiff2Options in the diff cache key

https://gerrit.wikimedia.org/r/951590

Maintenance_bot removed a project: Patch-For-Review.Aug 23 2023, 9:30 PM
HMonroy updated the task description. (Show Details)Aug 28 2023, 9:15 PM
gerritbot added a comment.Aug 28 2023, 9:20 PM

Change 952940 had a related patch set uploaded (by HMonroy; author: HMonroy):

[operations/mediawiki-config@master] wikidiff2: set maxSplitSize = 10 by default

https://gerrit.wikimedia.org/r/952940

gerritbot added a project: Patch-For-Review.Aug 28 2023, 9:21 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 30 2023, 1:02 AM
gerritbot added a comment.Aug 30 2023, 8:04 PM

Change 952940 merged by jenkins-bot:

[operations/mediawiki-config@master] wikidiff2: set maxSplitSize = 10 by default

https://gerrit.wikimedia.org/r/952940

Stashbot added a comment.Aug 30 2023, 8:05 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-30T20:05:00Z] <hmonroy@deploy1002> Started scap: Backport for [[gerrit:952940|wikidiff2: set maxSplitSize = 10 by default (T341754)]]

Stashbot added a comment.Aug 30 2023, 8:06 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-30T20:06:38Z] <hmonroy@deploy1002> hmonroy: Backport for [[gerrit:952940|wikidiff2: set maxSplitSize = 10 by default (T341754)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2023, 8:10 PM
Stashbot added a comment.Aug 30 2023, 8:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-30T20:14:13Z] <hmonroy@deploy1002> Finished scap: Backport for [[gerrit:952940|wikidiff2: set maxSplitSize = 10 by default (T341754)]] (duration: 09m 13s)

HMonroy updated the task description. (Show Details)Aug 30 2023, 8:58 PM
dmaza added subscribers: KSiebert, dmaza.Sep 19 2023, 9:06 PM

@HMonroy @KSiebert I think T341753: Wikidiff2 paragraph split parameter tuning can stand on its own and does not need to be part of this deployment task. Should we resolve this one?

MusikAnimal closed this task as Resolved.Sep 20 2023, 6:13 PM
MusikAnimal moved this task from In Development 💻 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.
MusikAnimal updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits