Page MenuHomePhabricator
Create Task
Maniphest T341389

Mentor dashboard: Ensure temporary accounts are not listed in Mentee overview.
Closed, ResolvedPublic
Actions

Description

User story & summary:

As a Mentor, I want to only see regular account holders in the Mentee overview, so that I can support active mentees rather than temporary accounts.

Background & research:

This task is important because temporary account holders will not have access to Growth features like mentorship.

Acceptance Criteria:

Given I'm a Mentor,
When I view the Mentor dashboard's Mentee overview,
Then I don't see temporary accounts listed

Details

SubjectRepoBranchLines +/-
Mentee overview: Exclude temporary accountsmediawiki/extensions/GrowthExperimentsmaster+14 -0
TempUserConfig: Add getMatchPatternmediawiki/coremaster+85 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

KStoller-WMF created this task.Jul 7 2023, 9:23 PM
KStoller-WMF mentioned this in T327420: Growth: Engineering testing for IP Masking.Jul 7 2023, 9:28 PM
JJMC89 added a project: GrowthExperiments.Jul 7 2023, 9:31 PM
Urbanecm_WMF edited projects, added GrowthExperiments-PersonalizedPraise, Growth-Positive-Reinforcement; removed GrowthExperiments.Jul 17 2023, 11:00 AM
Maintenance_bot added a project: GrowthExperiments-Mentorship.Jul 17 2023, 11:30 AM
Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Jul 17 2023, 12:15 PM
KStoller-WMF triaged this task as Low priority.Jul 24 2023, 4:18 AM
KStoller-WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Aug 2 2023, 1:53 PM

Change 944908 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] TempUserConfig: Add getMatchPattern

https://gerrit.wikimedia.org/r/944908

gerritbot added a project: Patch-For-Review.Aug 2 2023, 1:53 PM

Change 944909 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Exclude temporary accounts

https://gerrit.wikimedia.org/r/944909

Urbanecm_WMF claimed this task.Aug 2 2023, 1:53 PM
Urbanecm_WMF moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Aug 4 2023, 6:57 AM

Change 944908 merged by jenkins-bot:

[mediawiki/core@master] TempUserConfig: Add getMatchPattern

https://gerrit.wikimedia.org/r/944908

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 4 2023, 7:00 AM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 21 2023, 9:42 AM
gerritbot added a comment.Aug 21 2023, 10:02 AM

Change 944909 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Exclude temporary accounts

https://gerrit.wikimedia.org/r/944909

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2023, 10:11 AM
Urbanecm_WMF moved this task from In Progress to Ready for QA on the GrowthExperiments-Mentorship board.Aug 21 2023, 10:13 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 26 2023, 5:31 AM
Etonkovidova added subscribers: Urbanecm, Etonkovidova.

Checked in betalabs

  • there was only one case when a temp user has a mentor:

https://de.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=xml&list=growthmentormentee&gemmmentor=Dom_walden
The user account *Unregistered 2505 was created before the fix; currently mentors cannot claim temp users as mentees.

  • when a mentor attempts to claim a temp user as a mentee on Special:ClaimMentee form
    • a temp user name is not recognized (the correct behavior)
    • a mentor is able to click on 'Submit' button (Submit button is always active)
    • the generic messages "There are problems with some of your input." and "This value is required." are displayed.

The 'Submit' button should not be active if there is no valid input. For example, Preferences-Notifications Mute users features doesn't Submit active when non-exisiting usernames are entered. Filed as T345019: [minor] Special:ClaimMentee - improvements for handling invalid input . @Urbanecm - please take a look at the task; it's more like suggestions than a bug report.

Urbanecm_WMF added a project: IP-Masking-Growth-Team.Aug 29 2023, 2:07 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 29 2023, 11:01 PM
Etonkovidova closed this task as Resolved.Sep 25 2023, 10:45 PM
Etonkovidova mentioned this in T341839: [QA task] IP masking - temp users testing in production.

Closing as Resolved (will be checked in production as part of T341839: [QA task] IP masking - temp users testing in production

Etonkovidova mentioned this in T341390: Mentor dashboard: Ensure temporary accounts are not recommended as praiseworthy mentees in Personalized praise..Sep 29 2023, 5:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits