Page MenuHomePhabricator
Create Task
Maniphest T286775

Tag edits made via Termbox v2
Closed, ResolvedPublic
Actions

Description

Tag edits that are made using the new Termbox, aka Termbox v2, aka Mobile Termbox, aka wikibase/termbox.git.

The tags should be configurable, defaulting to an empty list ([]).

Details

SubjectRepoBranchLines +/-
Revert "Don't set termbox v2 tags yet"operations/mediawiki-configmaster+1 -2
Update termboxmediawiki/extensions/Wikibasewmf/1.37.0-wmf.18+1 -1
Update termboxmediawiki/extensions/Wikibasewmf/1.37.0-wmf.19+1 -1
Update termboxmediawiki/extensions/Wikibasemaster+1 -1
Correctly turn tags array into a string for the APIwikibase/termboxmaster+3 -3
Join tags properlywikibase/termboxmaster+1 -1
Tag Termbox editsmediawiki/extensions/Wikibasemaster+24 -2
Tag edits with configuration from ResourceLoaderwikibase/termboxmaster+31 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lucas_Werkmeister_WMDE created this task.Jul 16 2021, 11:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2021, 11:06 AM
• Lucas_Werkmeister_WMDE added a comment.Jul 19 2021, 3:57 PM

Getting the config into termbox will probably be the trickiest part. We can get a value using mwWindow.mw.config.get() in client-entry.ts, but for that we need something to define the new config variable; a new ResourceLoader module would be easy (like mw.config.values.wbSiteDetails or mw.config.values.wbRepo), but each new ResourceLoader module carries a cost, so ideally we’d like to avoid that.

I think it might be possible to squash this into the same module, with something like

'wikibase.termbox' => $wikibaseTermboxPaths + [
    'class' => TermboxModule::class,
    'packageFiles' => [
        'termbox-entry.js',
        [
            'name' => 'config.json',
            'content' => [ ... ], // JSON-encoded by ResourceLoader
        ],
        'dist/wikibase.termbox.main.js',
    ],
    // ...
],

where termbox-entry.js is something like

mw.config.set( 'wbTermboxConfig', require( './config.json' ) );
require( 'dist/wikibase.termbox.main.js' );

to move the config from the package file (which the webpack’ed termbox probably can’t access directly?) into mw.config and then load the real entrypoint. But that requires packageFiles, and I don’t know if termbox will work in that mode (currently it’s a legacy / "scripts" module).

• Lucas_Werkmeister_WMDE claimed this task.Jul 20 2021, 8:28 AM
• Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
• Manuel subscribed.Jul 20 2021, 10:18 AM
• Lucas_Werkmeister_WMDE added a comment.Jul 20 2021, 3:05 PM

But that requires packageFiles, and I don’t know if termbox will work in that mode (currently it’s a legacy / "scripts" module).

It’s broken on MediaWiki master (T286996), but with the fix for that, it seems to work. So that might be something to pursue once the ResourceLoader fix is merged.

• Lucas_Werkmeister_WMDE added a subtask: T286996: ResourceLoader incorrectly minifies Wikibase Termbox JS in package module.Jul 21 2021, 1:17 PM
gerritbot added a comment.Jul 21 2021, 3:49 PM

Change 705940 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikibase/termbox@master] Tag edits with configuration from ResourceLoader

https://gerrit.wikimedia.org/r/705940

gerritbot added a project: Patch-For-Review.Jul 21 2021, 3:49 PM

Change 705941 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Tag Termbox edits

https://gerrit.wikimedia.org/r/705941

• Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 22 2021, 8:51 AM
• Lucas_Werkmeister_WMDE closed subtask T286996: ResourceLoader incorrectly minifies Wikibase Termbox JS in package module as Resolved.Jul 28 2021, 2:40 PM
• Lucas_Werkmeister_WMDE mentioned this in T286996: ResourceLoader incorrectly minifies Wikibase Termbox JS in package module.
gerritbot added a comment.Aug 2 2021, 4:05 PM

Change 705940 merged by jenkins-bot:

[wikibase/termbox@master] Tag edits with configuration from ResourceLoader

https://gerrit.wikimedia.org/r/705940

• Lucas_Werkmeister_WMDE mentioned this in rWBTB3e15930dd3a3: Tag edits with configuration from ResourceLoader.Aug 2 2021, 4:22 PM
gerritbot added a comment.Aug 3 2021, 10:01 AM

Change 705941 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Tag Termbox edits

https://gerrit.wikimedia.org/r/705941

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2021, 10:10 AM
• Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 3 2021, 10:59 AM
• Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 3 2021, 3:00 PM
• Lucas_Werkmeister_WMDE reopened this task as Open.Aug 16 2021, 10:28 AM
• Lucas_Werkmeister_WMDE moved this task from Done to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Doesn’t work with more than one tag.

gerritbot added a comment.Aug 16 2021, 10:44 AM

Change 713236 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikibase/termbox@master] Correctly turn tags array into a string for the API

https://gerrit.wikimedia.org/r/713236

gerritbot added a project: Patch-For-Review.Aug 16 2021, 10:44 AM
• Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 16 2021, 10:45 AM
gerritbot added a comment.Aug 16 2021, 6:11 PM

Change 713302 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[wikibase/termbox@master] Join tags properly

https://gerrit.wikimedia.org/r/713302

gerritbot added a comment.Aug 16 2021, 6:12 PM

Change 713302 abandoned by Ladsgroup:

[wikibase/termbox@master] Join tags properly

Reason:

https://gerrit.wikimedia.org/r/713302

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 16 2021, 6:13 PM
gerritbot added a comment.Aug 16 2021, 6:16 PM

Change 713236 merged by jenkins-bot:

[wikibase/termbox@master] Correctly turn tags array into a string for the API

https://gerrit.wikimedia.org/r/713236

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2021, 7:10 PM
• Lucas_Werkmeister_WMDE mentioned this in rWBTBb2be98b9ae9e: Correctly turn tags array into a string for the API.Aug 16 2021, 7:20 PM
• Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 17 2021, 8:02 AM
gerritbot added a comment.Aug 17 2021, 8:04 AM

Change 713436 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/713436

gerritbot added a project: Patch-For-Review.Aug 17 2021, 8:04 AM
• Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 17 2021, 8:04 AM
gerritbot added a comment.Aug 17 2021, 4:13 PM

Change 713436 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update termbox

https://gerrit.wikimedia.org/r/713436

• Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 17 2021, 4:32 PM

I figure we want to backport this to wmf.19, but let’s wait until that has started to roll out, backports early in the train can be awkward.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.20; 2021-08-23); removed MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 17 2021, 5:00 PM
gerritbot added a comment.Aug 18 2021, 11:04 AM

Change 713513 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.19] Update termbox

https://gerrit.wikimedia.org/r/713513

gerritbot added a comment.Aug 19 2021, 10:01 AM

Change 713523 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.18] Update termbox

https://gerrit.wikimedia.org/r/713523

gerritbot added a comment.Aug 19 2021, 10:03 AM

Change 713824 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Revert \"Don't set termbox v2 tags yet\"

https://gerrit.wikimedia.org/r/713824

gerritbot added a comment.Aug 19 2021, 11:27 AM

Change 713824 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert \"Don't set termbox v2 tags yet\"

https://gerrit.wikimedia.org/r/713824

gerritbot added a comment.Aug 19 2021, 11:28 AM

Change 713513 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.19] Update termbox

https://gerrit.wikimedia.org/r/713513

Stashbot mentioned this in T236893: Tag all edits made via Wikibase View and Wikibase Client.Aug 19 2021, 11:40 AM

Mentioned in SAL (#wikimedia-operations) [2021-08-19T11:40:26Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.37.0-wmf.19/extensions/Wikibase/view/lib/wikibase-termbox/: Backport: [[gerrit:713513|Update termbox (T236893, T286775)]] (duration: 01m 08s)

Stashbot added a comment.Aug 19 2021, 11:42 AM

Mentioned in SAL (#wikimedia-operations) [2021-08-19T11:42:00Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:713824|Revert "Don't set termbox v2 tags yet" (T236893, T286775)]] (duration: 01m 06s)

Ladsgroup moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 19 2021, 11:45 AM
• Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 19 2021, 11:54 AM
• Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Let’s close this and leave verification to the parent task.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.19; 2021-08-16); removed MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 19 2021, 12:00 PM
gerritbot added a comment.Aug 19 2021, 12:07 PM

Change 713523 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.18] Update termbox

https://gerrit.wikimedia.org/r/713523

Stashbot added a comment.Aug 19 2021, 12:11 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-19T12:11:19Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.37.0-wmf.18/extensions/Wikibase/view/lib/wikibase-termbox/: Backport: [[gerrit:713523|Update termbox (T236893, T286775)]] (duration: 01m 08s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 2021-08-09); removed MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 19 2021, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits