Skip to content

Conversation

@apoorvapendse
Copy link
Collaborator

Fixes: https://chat.zulip.org/#narrow/channel/101-design/topic/muted.20user.20UX.20for.20DMs/with/2321412

How changes were tested:

Screenshots and screen captures:

muted-user-pill-demo.mp4
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@apoorvapendse apoorvapendse force-pushed the dm-muted-user-pill branch 2 times, most recently from 194e2aa to 7975199 Compare December 11, 2025 14:12
height: var(--length-input-pill-exit);
display: flex;
justify-content: center;
align-items: center;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that this doesn't cause any side effects on the exit expand buttons.

@apoorvapendse apoorvapendse force-pushed the dm-muted-user-pill branch 2 times, most recently from beeb2c5 to 3bbab75 Compare December 11, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants