Skip to content

message_report: Improve report template. #37012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timabbott merged 9 commits into from
Dec 16, 2025
Merged

message_report: Improve report template. #37012

timabbott merged 9 commits into from
Dec 16, 2025

Conversation

@PieterCK
Copy link
Collaborator

@PieterCK PieterCK commented Dec 11, 2025 •
edited
Loading

Changes:

  • Removed bold formatting in spoiler bar, broken link should appear as normal text.
  • Added reported message date sent as global time in report template.
  • Updated message report topic format.

Fixes: #36997

Screenshots and screen captures:

  • Public channel message report

    Before After
    image image

  • Private channel message report (Updated December 12)

    Before After
    image image

  • One-on-one message report

    Before After
    image image

  • Group DM report

    Before After
    image image

  • Self message report

    Before After
    image image
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@PieterCK PieterCK force-pushed the improve-mesage-report-feature branch 2 times, most recently from c6fbbd1 to 2980fa5 Compare December 11, 2025 13:51
@zulipbot zulipbot added size: L and removed size: M labels Dec 11, 2025
@PieterCK PieterCK marked this pull request as ready for review December 11, 2025 14:32
@PieterCK
Copy link
Collaborator Author

PieterCK commented Dec 11, 2025

@alya -- This is ready for review!

@alya
Copy link
Contributor

alya commented Dec 11, 2025

I don't know if we want to do it separately, but we should still fix private channel message links not being linked.

@alya
Copy link
Contributor

alya commented Dec 11, 2025

The topic should be {name} moderation, not {name}'s moderation.

@timabbott
Copy link
Member

timabbott commented Dec 11, 2025

we should still fix private channel message links not being linked.

This should be an easy change here, we just need to pass acting_user to the function to send the message.

timabbott
timabbott reviewed Dec 11, 2025
View reviewed changes
@PieterCK PieterCK force-pushed the improve-mesage-report-feature branch from 2980fa5 to c31cfcf Compare December 12, 2025 07:04
@PieterCK
Copy link
Collaborator Author

PieterCK commented Dec 12, 2025

Updates:

  • Fixed the report topic, previously it was {reported_user}'s moderation.
  • Private channel link syntax is now a proper link.
    525757807-408811e2-f50c-4356-bba8-e7a8eb6b5645

@alya
Copy link
Contributor

alya commented Dec 12, 2025

Sweet! @timabbott Let me know if you need me to re-test.

@alya alya added the integration review Added by maintainers when a PR may be ready for integration. label Dec 12, 2025
timabbott
timabbott reviewed Dec 12, 2025
View reviewed changes
timabbott
timabbott reviewed Dec 12, 2025
View reviewed changes
timabbott
timabbott reviewed Dec 12, 2025
View reviewed changes
timabbott
timabbott reviewed Dec 12, 2025
View reviewed changes
@PieterCK PieterCK marked this pull request as draft December 15, 2025 12:57
@PieterCK PieterCK force-pushed the improve-mesage-report-feature branch from c31cfcf to 026a63c Compare December 15, 2025 15:42
@zulipbot zulipbot added size: XL and removed size: L labels Dec 15, 2025
@PieterCK PieterCK force-pushed the improve-mesage-report-feature branch from 026a63c to 49d18b6 Compare December 16, 2025 09:56
@PieterCK PieterCK force-pushed the improve-mesage-report-feature branch from 49d18b6 to 179ec1a Compare December 16, 2025 09:56
@PieterCK PieterCK force-pushed the improve-mesage-report-feature branch from 179ec1a to 7d63a6b Compare December 16, 2025 09:58
@PieterCK
Copy link
Collaborator Author

PieterCK commented Dec 16, 2025 •
edited
Loading

@timabbott -- I think this is ready for review! The main changes are a new set of refactoring commits to greatly simplify test logics, and the use of time_machine.travel to help with end-to-end test of message date sent. Manually re-tested the various cases listed in the PR description too.

@PieterCK PieterCK marked this pull request as ready for review December 16, 2025 10:52
@timabbott timabbott merged commit cb35529 into zulip:main Dec 16, 2025
8 checks passed
@timabbott
Copy link
Member

timabbott commented Dec 16, 2025

Great, merged, thanks @PieterCK! I think this feature is coming together very nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timabbott timabbott timabbott left review comments

Assignees

No one assigned

Labels

integration review Added by maintainers when a PR may be ready for integration. size: XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvements to message reporting feature

4 participants

@PieterCK @alya @timabbott @zulipbot