Duplicate bots panel for "Personal" tab to fix keyboard navigation. #37010

sahil839 · 2025-12-11T10:15:00Z

First commit is a preparatory commit.
Second commit is to duplicate bots panel for "Personal" tab to fix keyboard navigation.

Fixes:

Screenshots and screen captures:

Screencast.from.2025-12-11.15-45-32.webm

Self-review checklist

Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

Explains differences from previous plans (e.g., issue description).
Highlights technical choices and bugs encountered.
Calls out remaining decisions and concerns.
Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

Each commit is a coherent idea.
Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

Visual appearance of the changes.
Responsiveness and internationalization.
Strings and tooltips.
End-to-end functionality of buttons, interactions and flows.
Corner cases, error conditions, and easily imagined bugs.

timabbott · 2025-12-17T00:37:22Z

@shubham-padia can you do maintainer review on this one?

shubham-padia · 2025-12-22T18:31:24Z

The settings header is now Settings / BotsBots since we have two elements with data-section=bots.

shubham-padia

Works great in testing! Only behavioural thing I could notice was the BotsBots thing mentioned in another comment.

Left some comments mostly focusing on deduplication.

shubham-padia · 2025-12-22T19:05:08Z

web/styles/settings.css

    #admin-user-list,
-    #admin-bot-list {
+    #admin-bot-list,
+    #personal-bot-list {


I'm not sure if it's worth the extra effort on a less-touched part of the codebase, but I think it would be better to have a prefix agnostic selector here instead of duplicating it.

I plan to refactor the classes and ID names later mainly because admin-bot-list does not seem correct since it is actionable for non-admins as well. So, I think we can handle this then.

shubham-padia · 2025-12-22T19:07:43Z

web/src/settings_panel_menu.ts

+                $(".personal-bot-settings-switcher"),
+            );
+        }
+    }


Maybe we can also deduplicate b/w show_personal_bot_settings_toggler and show_org_bot_settings_toggler by accepting a prefix and a toggler instance?

Added show_bot_settings_toggler function for this.

shubham-padia · 2025-12-22T19:11:59Z

web/src/settings_panel_menu.ts

+                }
+                $(`[data-bot-settings-section="${CSS.escape(key)}"]`).show();
+            },
+        });


Should be deduplicating the toggle creating logic. We could accept a prefix and a function to set the settings_tab e.g. set_bot_personal_settings_tab. Another comment of mine also proposes changing that function such that it accepts a prefix.

Added function to deduplicate creating logic as well.

shubham-padia · 2025-12-22T19:12:53Z

web/src/settings_panel_menu.ts

        this.current_tab = this.$curr_li.attr("data-section")!;
        this.current_user_settings_tab = "active";
        this.current_bot_settings_tab = "all-bots";
+        this.current_bot_personal_settings_tab = "your-bots";


I am thinking whether we could have

this.current_bot_settings_tab = {
"personal": "your-bots",
"org": "all-bots"
}

Then we can change the set settings tab to pass prefix as well and we won't need two set settings tab functions.

If we don't end up doing this, we should look at renaming instances of bot_settings which actually mean org_bot_settings e.g. current_bot_settings_tab

Made this change of current_bot_settings_tab being an object.

shubham-padia · 2025-12-22T19:16:19Z

web/src/settings_bots.ts

+    }
+    if (personal_your_bots_section.list_widget) {
+        personal_your_bots_section.list_widget.replace_list_data(bot_user_ids_for_current_owner);
+    }


Would we end up redrawing personal bots section when redrawing org your bots section always?

I don't think so, we have four separate ListWidget, two ("Your bots" and "All bots") each for "Personal" and "Organization" and we redraw them only if they have been set up once previously.

shubham-padia · 2025-12-22T19:57:12Z

last commit has typo in maintaing

sahil839 · 2025-12-23T11:55:07Z

Made the changes as per feedback. Posted replies to the comments as well. I also remember to update the lock-icon behavior in the left panel, will push update for that soon.

sahil839 · 2025-12-23T16:05:37Z

Added a commit to fix lock icon to not be shown when user can either create bots or can manage any bot as discussed on CZO. Also updated the tooltip for the lock icon to be You do not have permission to create or manage bots..

shubham-padia

Looks great! Just need to clarify one question, rest should be fine.

shubham-padia · 2025-12-23T16:53:02Z

web/src/ui_init.js

    drafts.initialize(); // Must happen before reload_setup.initialize()
    reload_setup.initialize();
    unread.initialize(state_data.unread);
-    bot_data.initialize(state_data.bot); // Must happen after people.initialize()


Why did we move this up?

We need to call this before settings.initialize so that lock icon can be shown for a non-admin correctly based on if they own any bot to manage or not. I will add a comment on that.

We always pass a string value to set_bot_settings_tab in settings_panel_menu.ts, so we can update the type of variable to "string" from "string | undefined".

We previously showed lock icon for "Bots" panel in left sidebar when user was not allowed to create new bots even when user could manage other bots. This commit updates that to not show lock icon when the user can manage bots as the panel is still useful to that user. Also updated the tooltip to be more clear about what permission the user doesn't have.

This commit does some preparatory work for duplicating bots panel in "Personal" tab, i.e. we do not redirect to the "Organization" tab bots panel when clicking on bots panel in "Personal" tab. The changes done are - - Updated IDs in templates to have a prefix so that the same template can be reused without duplicate IDs. - Added classes to some elements so that it is easy to query them using class selectors instead of ID. - Updated JS code to rename variables and function declarations to accept container elements and/or section so that same JS code can be used for both bot panels. - Did some changes in settings_panel_menu.ts to support same "section" value for sections in "Personal" and "Organization" tabs. - Updated tab related code in settings_panel_menu.ts to support two bot panels. And also updated the toggler related code so that we can avoid code duplication when using togglers for two bot panels.

Previously, clicking on "Bots" in "Personal" tab redirected to bots panel in "Organization" tab. This commit changes this behavior to not redirect and instead show the same content shown in bots panel in "Organization" tab in the "Personal" tab and opening "Your bots" section by default instead of "All bots". Now "Bots" in both "Personal" and "Organization" opens different sections independent of each other maintaining their individual filter and search value selected. This helps in maintaining the keyboard navigation using up/down keys in the settings sidebar which was broken due to redirecting. We also now show lock icon for the personal bots panel if user does not have permission to create or manage bots like we do for organization bots panel.

shubham-padia · 2025-12-24T06:29:09Z

Looks good!

alya · 2025-12-25T04:12:52Z

Works for me in manual testing!

By the way, since I was playing with keyboard nav, I noticed that pressing "Enter" on "All bots" or "Your bots" tabs doesn't work -- the focus just bounces to the "Add a new bot" button without switching panels. Not sure if this is known?

sahil839 · 2025-12-25T06:45:00Z

It is same for the users panel as well where focus bounces on the role dropdown. Will investigate.

zulipbot added the size: XL label Dec 11, 2025

sahil839 force-pushed the bots-panel branch from e71c3d6 to e3e433a Compare December 11, 2025 13:29

timabbott added the maintainer review PR is ready for review by Zulip maintainers. label Dec 17, 2025

timabbott assigned shubham-padia Dec 17, 2025

shubham-padia reviewed Dec 22, 2025

View reviewed changes

sahil839 force-pushed the bots-panel branch 2 times, most recently from 2abd46e to fc237d1 Compare December 23, 2025 11:09

sahil839 force-pushed the bots-panel branch from fc237d1 to 898a7d0 Compare December 23, 2025 15:31

shubham-padia reviewed Dec 23, 2025

View reviewed changes

sahil839 added 4 commits December 24, 2025 08:29

settings: Fix type of settings_tab in set_bot_settings_tab.

0d9c8a7

We always pass a string value to set_bot_settings_tab in settings_panel_menu.ts, so we can update the type of variable to "string" from "string | undefined".

sahil839 force-pushed the bots-panel branch from 898a7d0 to f419978 Compare December 24, 2025 02:59

shubham-padia added integration review Added by maintainers when a PR may be ready for integration. and removed integration review Added by maintainers when a PR may be ready for integration. labels Dec 24, 2025

shubham-padia removed their assignment Dec 24, 2025

sahil839 added integration review Added by maintainers when a PR may be ready for integration. and removed maintainer review PR is ready for review by Zulip maintainers. labels Dec 24, 2025

Uh oh!

Duplicate bots panel for "Personal" tab to fix keyboard navigation. #37010

Are you sure you want to change the base?

Duplicate bots panel for "Personal" tab to fix keyboard navigation. #37010

Conversation

sahil839 commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timabbott commented Dec 17, 2025

Uh oh!

shubham-padia commented Dec 22, 2025

Uh oh!

shubham-padia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sahil839 Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham-padia commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sahil839 commented Dec 23, 2025

Uh oh!

sahil839 commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham-padia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubham-padia commented Dec 24, 2025

Uh oh!

alya commented Dec 25, 2025

Uh oh!

sahil839 commented Dec 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sahil839 commented Dec 11, 2025 •

edited

Loading

sahil839 Dec 23, 2025 •

edited

Loading

shubham-padia commented Dec 22, 2025 •

edited

Loading

sahil839 commented Dec 23, 2025 •

edited

Loading