Skip to content

Conversation

@alexmv
Copy link
Collaborator

@alexmv alexmv commented Dec 10, 2025

The default of one-per-core can be too many -- and Docker needs to control this explicitly, as the number of cores is less defined.

Fixes:

How changes were tested:

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

The default of one-per-core can be too many -- and Docker needs to
control this explicitly, as the number of cores is less defined.
@alexmv alexmv added the backport candidate Items we should consider backporting to the bug fix release series. label Dec 10, 2025
@timabbott timabbott merged commit 172c52f into zulip:main Dec 12, 2025
19 checks passed
@timabbott
Copy link
Member

Merged, thanks @alexmv!

@alexmv
Copy link
Collaborator Author

alexmv commented Dec 17, 2025

Backported in #37131 (334c8d5)

@alexmv alexmv removed the backport candidate Items we should consider backporting to the bug fix release series. label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants