Put subscribe dividers inside message group #36984
Open
+211
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratik-pc
force-pushed
the
issue-36905-put-subscribe-dividers-inside-message-group
branch
from
64e5a10 to
d95318a
Compare
timabbott
reviewed
Dec 11, 2025
timabbott
reviewed
Dec 11, 2025
pratik-pc
force-pushed
the
issue-36905-put-subscribe-dividers-inside-message-group
branch
2 times, most recently
from
f8b4657 to
6eeb414
Compare
pratik-pc
force-pushed
the
issue-36905-put-subscribe-dividers-inside-message-group
branch
3 times, most recently
from
137cb82 to
ba74352
Compare
Contributor
|
The notice text should not be the same color as message text. We can try 75% opacity, which looks to be what the date has? |
Contributor
|
Let's see how that looks. We may want to do small caps after all, to avoid blending in with message text, if it's not enough to make it feel distinct. |
Collaborator
Author
@alya This is with 75% opacity for subscription status |
Earlier, message groups were split for all subscription markers. What it means in practice is that even if two messages from same topic were in succession and a subscription marker was in between these two messages, they would be forced to split into two separate message groups, even in topic narrows. We change this message group splitting based on subscription markers and only split when message recipients are different. The earlier subscription markers are now moved inside the message group and render on the same line as date dividers. `want_subscription_status_divider` is always false for first message container in the group and for private messages. Fixes: zulip#36905.
pratik-pc
force-pushed
the
issue-36905-put-subscribe-dividers-inside-message-group
branch
from
ba74352 to
5e3924d
Compare
Contributor
|
Hm, why does it look different from the timestamp? Is that an illusion? FWIF, the inspector also is not identical (dark theme): Notice |
Contributor
|
Anyway, it would be great if you could post a version with matching just the color of the timestamp vs. matching color and font (both light and dark theme) for discussion in #design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently two consecutive messages are split into two message groups if the user subscribed/unsubscribed between them even if the recipient is same(both message are in same topic).
We move such bookend divider which have same recipient above and below it into the message group itself and prevent it from making two separate message groups. We still show bookend in between two message groups if the message recipient is different.
We use
want_subscription_status_dividerin message containers to denote if we want subscription divider above the message. Obviously this meanswant_subscription_status_dividerof top most message in a message group isfalse.For narrow space, date content has more preference to fit its content than subscription status(subscription text ellipsis).
Fixes: #36905.
How changes were tested:
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: