Add zng_ prefix to internal functions to avoid linking conflicts with zlib. #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmoinvaz
changed the title
nmoinvaz
changed the title
Dead2
reviewed
Jun 22, 2019
…be okay since the functions are static.
|
I have made the PR so it is only renaming of functions like you suggested. |
Closed
|
Looks like Travis CI stalled on one instance. |
Dead2
changed the title
|
Looks good to me, and it passes my tests. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds zng_ prefix to certain internal functions to allow for dual linking both zlib & zlib-ng. #358, #360