Skip to content

Add translation for Simplified Chinese #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2024
Merged

Add translation for Simplified Chinese #298

merged 3 commits into from
Dec 11, 2024

Conversation

JimmyKmi
Copy link
Contributor

@JimmyKmi JimmyKmi commented Nov 26, 2024 •
edited
Loading

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024

@JimmyKmi is attempting to deploy a commit to the zitadel Team on Vercel.

A member of the Team first needs to authorize it.

@fforootd fforootd requested a review from peintnermax November 29, 2024 10:13
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 8:37am

peintnermax
peintnermax approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@peintnermax peintnermax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @JimmyKmi 🙏

@peintnermax peintnermax merged commit f6b257b into zitadel:main Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peintnermax peintnermax peintnermax approved these changes

Assignees
No one assigned
Labels
os-contribution
Projects
Product Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JimmyKmi @peintnermax @hifabienne