Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to use zio-profiling with our benchmarks #883

Closed
wants to merge 11 commits into from
Closed

Try to use zio-profiling with our benchmarks #883

wants to merge 11 commits into from

Conversation

guizmaii
Copy link
Member

@guizmaii guizmaii commented May 31, 2023 •
edited
Loading

To try to run a benchmark, in an sbt console:

clean;Test/compile;zioKafkaBench/Jmh/run -wi 20 -i 10 -r 1 -w 1 -t 1 -f 1 -foe true -prof zio.profiling.jmh.JmhZioProfiler .*ConsumersComparisonBenchmark.manualZioKafka*

For now, it's failing with the following error:

[info] # Warmup Iteration   1: 19:05:35.308 [zio-default-blocking-1] WARN  k.server.BrokerMetadataCheckpoint - No meta.properties file under dir /var/folders/5r/0tttbjvx405d9c4pg69m6swh0000gn/T/kafka-logs4001693473086757478/meta.properties
[info] Error in benchmark run: Exception in thread "zio-fiber-19,18" java.lang.NullPointerException: Cannot invoke "zio.ZIO.ensuring(scala.Function0, Object)" because "zio$3" is null
[info] 	at zio.FiberRef$unsafe$$anon$2.$anonfun$locally$5(FiberRef.scala:472)
[info] 	at zio.kafka.consumer.internal.RunloopAccess.runloop(RunloopAccess.scala:44)
[info] 	at zio.kafka.consumer.internal.RunloopAccess.withRunloopZIO(RunloopAccess.scala:46)
[info] 	at zio.kafka.consumer.internal.RunloopAccess.subscribe(RunloopAccess.scala:88)
[info] 	at zio.kafka.consumer.Consumer.Live.partitionedAssignmentStream(Consumer.scala:224)
[info] 	at zio.kafka.consumer.Consumer.Live.partitionedAssignmentStream(Consumer.scala:222)
[info] 	at zio.kafka.consumer.Consumer.Live.plainStream(Consumer.scala:270)
[info] 	at zio.kafka.consumer.Consumer.Live.plainStream(Consumer.scala:270)
[info] 	at zio.kafka.bench.ConsumersComparisonBenchmark.manualZioKafka(ConsumersComparisonBenchmark.scala:147)
[info] <failure>
[info] java.lang.NullPointerException: Cannot invoke "zio.ZIO.ensuring(scala.Function0, Object)" because "zio$3" is null
[info] 	at zio.FiberRef$unsafe$$anon$2.$anonfun$locally$5(FiberRef.scala:472)
[info] 	at zio.internal.FiberRuntime.runLoop(FiberRuntime.scala:1067)
[info] 	at zio.internal.FiberRuntime.runLoop(FiberRuntime.scala:890)
[info] 	at zio.internal.FiberRuntime.runLoop(FiberRuntime.scala:890)
[info] 	at zio.internal.FiberRuntime.runLoop(FiberRuntime.scala:1024)
...

@guizmaii guizmaii mentioned this pull request May 31, 2023
Open
@guizmaii guizmaii force-pushed the fix_856 branch 2 times, most recently from 626029d to 61d78b9 Compare June 3, 2023 08:16
@guizmaii guizmaii mentioned this pull request Jun 3, 2023
Open
@guizmaii guizmaii force-pushed the fix_856 branch 8 times, most recently from fbf342f to 665b95e Compare June 8, 2023 08:39
@guizmaii guizmaii force-pushed the fix_856 branch 2 times, most recently from 48ccd25 to 3020be6 Compare June 12, 2023 15:46
@guizmaii guizmaii force-pushed the fix_856 branch 3 times, most recently from 7f6a167 to 9e118e0 Compare June 17, 2023 16:05
@guizmaii guizmaii force-pushed the fix_856 branch 4 times, most recently from 074bddf to 38a4ac1 Compare June 24, 2023 08:52
@guizmaii guizmaii force-pushed the fix_856 branch 5 times, most recently from b02471b to 6610059 Compare July 1, 2023 12:56
Base automatically changed from fix_856 to master July 1, 2023 13:23
@guizmaii guizmaii closed this Sep 28, 2023
@guizmaii guizmaii deleted the zio_profiling branch September 28, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikvanoosten erikvanoosten Awaiting requested review from erikvanoosten erikvanoosten will be requested when the pull request is marked ready for review erikvanoosten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@guizmaii