Skip to content

Commit

Permalink
Merge pull request juju#1684 from howbazaar/mess-to-jes
Browse files Browse the repository at this point in the history
Rename the MESS feature flag.

MESS is dead. Long live JES.

(Review request: http://reviews.vapour.ws/r/1012/)
  • Loading branch information
jujubot committed Feb 25, 2015
2 parents 60e8779 + d9a360c commit 7d501dc
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions api/environmentmanager/environmentmanager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func (s *environmentmanagerSuite) OpenAPI(c *gc.C) *environmentmanager.Client {
}

func (s *environmentmanagerSuite) TestConfigSkeleton(c *gc.C) {
s.SetFeatureFlags(feature.MESS)
s.SetFeatureFlags(feature.JES)
envManager := s.OpenAPI(c)
result, err := envManager.ConfigSkeleton("", "")
c.Assert(err, jc.ErrorIsNil)
Expand Down Expand Up @@ -70,14 +70,14 @@ func (s *environmentmanagerSuite) TestCreateEnvironmentFeatureNotEnabled(c *gc.C
}

func (s *environmentmanagerSuite) TestCreateEnvironmentMissingConfig(c *gc.C) {
s.SetFeatureFlags(feature.MESS)
s.SetFeatureFlags(feature.JES)
envManager := s.OpenAPI(c)
_, err := envManager.CreateEnvironment("owner", nil, nil)
c.Assert(err, gc.ErrorMatches, `creating config from values failed: name: expected string, got nothing`)
}

func (s *environmentmanagerSuite) TestCreateEnvironment(c *gc.C) {
s.SetFeatureFlags(feature.MESS)
s.SetFeatureFlags(feature.JES)
envManager := s.OpenAPI(c)
user := s.Factory.MakeUser(c, nil)
owner := user.UserTag().Username()
Expand All @@ -100,7 +100,7 @@ func (s *environmentmanagerSuite) TestListEnvironmentsBadUser(c *gc.C) {
}

func (s *environmentmanagerSuite) TestListEnvironments(c *gc.C) {
s.SetFeatureFlags(feature.MESS)
s.SetFeatureFlags(feature.JES)
owner := names.NewUserTag("user@remote")
s.Factory.MakeEnvironment(c, &factory.EnvParams{
Name: "first", Owner: owner}).Close()
Expand Down
2 changes: 1 addition & 1 deletion api/facadeversions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var _ = gc.Suite(&facadeVersionSuite{})

func (s *facadeVersionSuite) TestFacadeVersionsMatchServerVersions(c *gc.C) {
// Enable feature flags so we can see them all.
devFeatures := []string{feature.MESS, feature.Storage}
devFeatures := []string{feature.JES, feature.Storage}
s.SetFeatureFlags(strings.Join(devFeatures, ","))
// The client side code doesn't want to directly import the server side
// code just to list out what versions are available. However, we do
Expand Down
2 changes: 1 addition & 1 deletion apiserver/environmentmanager/environmentmanager.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
var logger = loggo.GetLogger("juju.apiserver.environmentmanager")

func init() {
common.RegisterStandardFacadeForFeature("EnvironmentManager", 1, NewEnvironmentManagerAPI, feature.MESS)
common.RegisterStandardFacadeForFeature("EnvironmentManager", 1, NewEnvironmentManagerAPI, feature.JES)
}

// EnvironmentManager defines the methods on the environmentmanager API end
Expand Down
4 changes: 2 additions & 2 deletions feature/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ package feature
// Actions is the name of the feature to enable action commands.
const Actions = "action"

// MESS stands for Multi-Environment State Server and controls access
// JES stands for Juju Environment Server and controls access
// to the apiserver endpoints, api client and CLI commands.
const MESS = "mess"
const JES = "jes"

// Storage is the name of the feature to enable storage commands
// and server-side functionality.
Expand Down

0 comments on commit 7d501dc

Please sign in to comment.