safe-chainの導入とnpmからpnpmへのマイグレーション #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm-igarashi-ryosuke
force-pushed
the
fix-migrate-pnpm
branch
from
1271d83 to
5051a02
Compare
Comment on lines
+31
to
+35
| - name: Install safe-chain | ||
| run: curl -fsSL https://raw.githubusercontent.com/AikidoSec/safe-chain/main/install-scripts/install-safe-chain.sh | sh -s -- --ci | ||
| env: | ||
| SAFE_CHAIN_VERSION: "1.2.1" | ||
|
|
| env: | ||
| SAFE_CHAIN_VERSION: "1.2.1" | ||
|
|
||
| # vsce が pnpm に対応してないので npm でインストールする。 |
Member
Author
There was a problem hiding this comment.
vsceがpnpmに対応していないのは変わっていないが、webpackでビルドしているので依存はないはず。 vsce publish に --no-dependencies をつければより確実です、と Claude Code が申しているので試してみます。
参考:
https://zenn.dev/kimuson/articles/vscode_extension_pnpm_workspace
| "eslint-plugin-import": "^2.26.0", | ||
| "mocha": "^10.0.0", | ||
| "natural-compare-lite": "^1.4.0", | ||
| "npm-run-all": "^4.1.5", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
すべてのプロセスを終了できないので、廃止するのはやめて、npm-run-all2を使うことにしました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
プルリクエストに含む内容の簡潔な記述
Resolves #
📋 Tasks
プルリクエストを作成いただく際、お手数ですが以下の内容についてご確認をお願いします。
canaryブランチに対するプルリクエストであるより詳しい内容は Pull Request Policy を参照してください。